Replace dataclasses with subclasses for better type inference

Yubico · Nov 18, 2024 · d6c71aa · d6c71aa
1 parent c35f76f
commit d6c71aa
Show file tree

Hide file tree

Showing 2 changed files with 239 additions and 178 deletions.
diff --git a/fido2/client.py b/fido2/client.py
@@ -35,7 +35,7 @@
 from .ctap2.extensions import (
     Ctap2Extension,
     ClientExtensionOutputs,
-    ExtensionProcessor,
+    AuthenticationExtensionProcessor,
 )
 from .webauthn import (
     Aaguid,
@@ -425,8 +425,8 @@ def __init__(
         self,
         client_data: CollectedClientData,
         assertions: Sequence[AssertionResponse],
-        extensions: Sequence[ExtensionProcessor],
-        pin_token: Optional[str],
+        extensions: Sequence[AuthenticationExtensionProcessor],
+        pin_token: Optional[bytes],
         pin_protocol: Optional[PinProtocol],
     ):
         super().__init__(client_data, assertions)
@@ -693,7 +693,7 @@ def _do_make():
             extension_inputs = {}
             try:
                 for ext in used_extensions:
-                    auth_input = ext.prepare_inputs(None)
+                    auth_input = ext.prepare_inputs()
                     if auth_input:
                         extension_inputs.update(auth_input)
             except ValueError as e: