Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use http_client from the internal spec in the _SpecFlattener.model_discovery. #386

Closed
wants to merge 2 commits into from

Conversation

kwist-sgr
Copy link

This will allow you to use bravado-core with the jsonschema > 4.0.

E.g. in the following case:

from bravado_core.spec import Spec
from bravado.requests_client import RequestsClient

http_client = RequestsClient()
spec = Spec.from_dict(spec_dict, origin_url=origin_url, config=config, http_client=http_client)

# This call can throw an error without the fix
flattened_spec = spec.deref_flattened_spec

@kwist-sgr kwist-sgr changed the title Use some parameters from the internal spec in the _SpecFlattener.model_discovery. Use http_client from the internal spec in the _SpecFlattener.model_discovery. Dec 9, 2021
@kwist-sgr kwist-sgr marked this pull request as draft December 9, 2021 14:29
@kwist-sgr
Copy link
Author

kwist-sgr commented Dec 10, 2021

bravado-core doesn't currently support jsonschema>4 - many tests fail.
I guess the reason is that the last release of bravado-core was before jsonschema v4 was released.

See also #385.

@kwist-sgr kwist-sgr closed this Dec 10, 2021
@kwist-sgr kwist-sgr deleted the spec-flattener branch December 10, 2021 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant