TRON-1850: Include starting pods in check for stuck jobs #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfongatyelp
requested review from
nemacysts,
bobokun,
EmanElsaban and
KaspariK
nemacysts
approved these changes
Feb 13, 2024
| @@ -251,7 +251,7 @@ def is_job_stuck( | |||
| ): | |||
| next_run_time = None | |||
| for job_run in job_runs: | |||
| states_to_check = {"running", "waiting"} | |||
| states_to_check = {"running", "waiting", "starting"} | |||
There was a problem hiding this comment.
heh, i like how we're pretty inconsistent re: sets and lists in this file :p
There was a problem hiding this comment.
we could also move this outside the loop so that we're not re-creating a set multiple times, but it's probably fine to punt on refactoring this script :p
There was a problem hiding this comment.
Hm good call, though i also briefly saw we had https://github.com/Yelp/Tron/blob/master/tron/core/jobrun.py#L456 which makes me wonder if we should just reuse this and why didn't we already, but agree I'll leave the archaeology for another time.
Co-authored-by: Luis Pérez <[email protected]>
nemacysts
approved these changes
Feb 13, 2024
bobokun
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can sometimes get stuck in state
startingif we somehow miss events coming in from k8s (or a pod somehow itself get stuck before it starts running).This should now consider these situations as
stuckjobs and actions alongside those that are actually running too long or waiting on a trigger, and adds some tests to verify. (These tests were confirmed to fail w/o the changes to include 'starting' jobs/actions).