Use total_seconds for timedeltas. Log job and jobrun names/runnums on serialization #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemacysts
approved these changes
Oct 31, 2024
tron/core/actionrun.py
Outdated
Comment on lines
763
to
765
| "retries_delay": state_data["retries_delay"].total_seconds() | ||
| if state_data["retries_delay"] | ||
| else None, |
There was a problem hiding this comment.
Suggested change
| "retries_delay": state_data["retries_delay"].total_seconds() | |
| if state_data["retries_delay"] | |
| else None, | |
| "retries_delay": state_data["retries_delay"].total_seconds() | |
| if state_data["retries_delay"] is not None | |
| else None, |
i think we'd want something like the above - unless there's no difference between None and 0 when deserializing back into a timedelta later :)
There was a problem hiding this comment.
Ah, true. I think it's ultimately the same in restart, but there is indeed a semantic difference.
KaspariK
commented
Oct 31, 2024
| @@ -204,8 +204,10 @@ def get_type_from_key(self, key: str) -> str: | |||
| def _serialize_item(self, key: Literal[runstate.JOB_STATE, runstate.JOB_RUN_STATE], state: Dict[str, Any]) -> Optional[str]: # type: ignore | |||
| try: | |||
| if key == runstate.JOB_STATE: | |||
| log.info(f"Serializing Job: {state.get('job_name')}") | |||
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think total_seconds is the easiest to convert back to timedelta later. I added some logging that might be noisier than we want longterm, but should make debugging these a lot easier.
Recreated the errors in infrastage and this does appear to resolve things.
Sidenote, I'm happy to leave this unmerged while doing more testing in dev/stage to maybe minimize the number of patch releases.