TRON-2208: Update non_retryable_exit_code behavior to treat as UNKNOWN #1000
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This keeps things as UNKNOWN if we happen to match a non_retryable_exit_code rather than straight to FAILED, since we are primarily using this feature to capture things which have gone LOST on kubernetes and as such, we can then use our sync_tron_state_from_k8s script to update the action state based on pod state, which would not be possible if we already marked it as FAIL.
This has been tested on infrastage and the test run that exited with a non_retryable_exit_code successfully got marked as
unknown
and did not attempt any retries, plus the sync_tron_state_from_k8s script reported it would be able to correct the state: