Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRON-2208: Update non_retryable_exit_code behavior to treat as UNKNOWN #1000

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

jfongatyelp
Copy link
Contributor

This keeps things as UNKNOWN if we happen to match a non_retryable_exit_code rather than straight to FAILED, since we are primarily using this feature to capture things which have gone LOST on kubernetes and as such, we can then use our sync_tron_state_from_k8s script to update the action state based on pod state, which would not be possible if we already marked it as FAIL.

This has been tested on infrastage and the test run that exited with a non_retryable_exit_code successfully got marked as unknown and did not attempt any retries, plus the sync_tron_state_from_k8s script reported it would be able to correct the state:

DEBUG:sync_tron_from_k8s:paasta-contract-monitor.test_no_retries.12.run state unknown needs updating to fail
INFO:sync_tron_from_k8s:Dry-Run: Would run ['tronctl-infrastage', 'fail', 'paasta-contract-monitor.test_no_retries.12.run']

@jfongatyelp jfongatyelp merged commit 0cfe0ba into master Sep 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants