-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed design + adding genre related content #13
Open
YaronMiro
wants to merge
31
commits into
master
Choose a base branch
from
te
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
YaronMiro
commented
May 27, 2015
- Add on the header add menu links to sort movies by gerne.
- Add on the info page related movies by genre carousel if such movies exists
- if no genre movies don't display block.
- count number of movies for css of view height.
- movie Info related movies design show full frame with black border dont overlay it.
- movie Info Shuffle related movies (random).
- Re-number movies after genre filter on homepage and bookmarks sort.
- fix top bottom gray bars.
- fix offset position responsive.
- fix movie summary poster anchor to click action.
Conflicts: app/scripts/services/bookmarks.js app/views/pages/movies/movies.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.