Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge 3.3.1 work into trunk #25

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Merge 3.3.1 work into trunk #25

wants to merge 12 commits into from

Conversation

triplingual
Copy link
Contributor

@triplingual triplingual commented Jun 7, 2023 •
edited
Loading

This PR will merge work done for the 3.3.1 core upgrade into the trunk. Specific
commits are as follows:

  • collapse_all refactored to expandAllByDefault
  • even though we will always have a parent institution, we should not require that
  • fix an HTML invalidity issue that is in core... and remember to make a pull request to core
  • merge updates, but keep our report a problem feature
  • update for local breadcrumb display
  • even less icons, given the fact that sometimes there is only one breadcrumb, and also because the record type is not always set as the correct one right now, and since the fall back is just a square, and yeah...
  • temp updates in plugin before we update our branch, right
  • quick patch to keep the repository browse lists rigid, rather than flexed
  • a central refactor is still in order, but for now...
  • update excluded fields
  • refined hide [CSS] rule for icons

payten and others added 10 commits November 8, 2022 10:49
@payten
collapse_all refactored to expandAllByDefault
8049cab
@fordmadox
even though we will always have a parent institution, we should not r…
364598d 
…equire that
@fordmadox
fix an HTML invalidity issue that is in core... and remember to make …
e515e8d 
…a pull request to core
@fordmadox
merge updates, but keep our report a problem feature
d40c982
@fordmadox
update for local breadcrumb display
c014803
@fordmadox
even less icons, given the fact that sometimes there is only one brea…
a0c0967 
…dcrumb, and also because the record type is not always set as the correct one right now, and since the fall back is just a square, and yeah...
@fordmadox
temp updates in plugin before we update our branch, right
00b7b0b
@fordmadox
quick patch to keep the repository browse lists rigid, rather than fl…
55b70a9 
…exed
@fordmadox
a central refactor is still in order, but for now...
8a088a6
@ucancallmealicia
update excluded fields
24ee938
@triplingual triplingual added enhancement New feature or request upgrade part of or consequent to a core version upgrade labels Jun 7, 2023
@triplingual
Refined hide rule for icons
670b1c7 
The patch inserted by @fordmadox was suitable at the time, but instances are showing up now where it ends up being too blunt. The refinement looks more narrowly for the icon styles alone
@triplingual triplingual marked this pull request as ready for review June 7, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ucancallmealicia ucancallmealicia Awaiting requested review from ucancallmealicia

Assignees
No one assigned
Labels
enhancement New feature or request upgrade part of or consequent to a core version upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@triplingual @payten @fordmadox @ucancallmealicia