This repository has been archived by the owner on Jul 15, 2019. It is now read-only.
Minor bugfix in order to make inserting data into table work #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, and thanks for a great code. But one small problem is that I found it impossible to create LSH index using the most current code in your repository. In CalculateHashes you try to fill in bins using standard code, computing projections in form floor( bias + projection*data/w). But the code, which tries to do that, accidentally have dimensions disagreement. I just fixed this using slice and transpose, and left the rest intact.
I plan to make your code run under Hadoop, so, if you are interested, let's stay in touch :-)