Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use plugin screenshots from the local "assets" directory. #463

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

timwiel
Copy link
Contributor

@timwiel timwiel commented Sep 29, 2021

Just like the icons and banners we can use screenshots from the assets directory

However the implmention needs to be slightly different as the screenshot captions are extracted from the readme.txt file and the screenshot files from the assets directory.

WP Standards taken from

@YahnisElsts
Copy link
Owner

That doesn't seem like the best idea. It looks like it combines the screenshots from the currently installed version with screenshot descriptions from the latest version. There's no guarantee that these things will match up correctly. Also, the screenshots would be shown in the "view details" pop-up, which is supposed to show information about the latest version, not about the installed version.

Using the locally stored icons and banners is probably fine because those parts of the plugin are very unlikely to change between versions. However, screenshots might not always stay the same. I think that if you want to show them, you would really have to retrieve them from the repository somehow. I'm not sure how feasible that is - for example, some hosts might have issues with hotlinking images from private repositories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants