Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding high score popup with sounds #719

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

Riyachauhan11
Copy link
Contributor

@Riyachauhan11 Riyachauhan11 commented Nov 7, 2024

πŸ› οΈ Fixes Issue

Fixes: #718

πŸ‘¨β€πŸ’» Description

What does this PR do?

displays a high score popup (customised in both light dark modes) when user beats their previous high score followed by a congratulatory sound effect.

πŸ“„ Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (adds or updates related documentation)

πŸ“· Screenshots/GIFs (if any)

Include screenshots or GIFs to demonstrate your changes

2024-11-08.01-33-50.mp4

βœ… Checklist

  • I am a participant of GSSoC-ext.
  • I have followed the contribution guidelines of this project.
  • I have made this change from my own.
  • I have taken help from some online resources.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have added documentation to explain my changes.

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

🀝 GSSoC Participation

  • This PR is submitted under the GSSoC program.
  • I have taken prior approval for this feature/fix.

Copy link

github-actions bot commented Nov 7, 2024

Thank you for submitting your pull request! πŸ™Œ We'll review it as soon as possible. In the meantime, please ensure that your changes align with our chaotic CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Nov 7, 2024

βœ… Deploy Preview for alienid ready!

Name Link
πŸ”¨ Latest commit 81607b0
πŸ” Latest deploy log https://app.netlify.com/sites/alienid/deploys/672d1c1ccf9a50000891cb93
😎 Deploy Preview https://deploy-preview-719--alienid.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 7, 2024

βœ… Deploy Preview for thunderous-starlight-9c463d ready!

Name Link
πŸ”¨ Latest commit 81607b0
πŸ” Latest deploy log https://app.netlify.com/sites/thunderous-starlight-9c463d/deploys/672d1c1cfcefff0008b37477
😎 Deploy Preview https://deploy-preview-719--thunderous-starlight-9c463d.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Riyachauhan11
Copy link
Contributor Author

@YadavAkhileshh pls review this pr

@YadavAkhileshh YadavAkhileshh merged commit 7089147 into YadavAkhileshh:main Nov 8, 2024
9 checks passed
@YadavAkhileshh YadavAkhileshh added gssoc24 gssoc-ext New feature or request level2 labels Nov 8, 2024
Copy link

github-actions bot commented Nov 8, 2024

πŸŽ‰πŸŽ‰ Thank you for your contribution! Your PR #719 has been merged! πŸŽ‰πŸŽ‰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc24 gssoc-ext New feature or request level2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FEATURE: add a high score popup modal with sounds
2 participants