Skip to content

Commit

Permalink
Improved solo high scores, basic band high scores (#883)
Browse files Browse the repository at this point in the history
* WIP Implementation of better solo high scores.
Solo high scores are now displayed when there is exactly one non-bot player present.
High scores are now retrieved per player, song and instrument. Added a new cache for the above when retrieving high scores for the same player + instrument for many songs in a row.
Removed instrument icon for high scores on Music Library song list, replaced with a FC indicator sprite (using a placeholder sprite for now).
Moved retrieval of solo high scores per song to MusicLibraryMenu.
Marked several methods as Obsolete

* Reworked Player High Scores due to feedback. Player High Scores now keep track of the best percentage and best score (matches existing behaviour)
Added basic implementation for Band High Scores
Removed magic number in RecommandedSongs

* Update Band High Scores cache when a new Band High Score is set.
Fixed Best percentage scores not being loaded.
Fixed Best percentage score not being displayed if its different to the best score.

* Fixed bug when saving a band high score for the first time.
Fixed best percentage not loading when multiple profiles have played the same song+instrument combination.

* Added new difficulty icons, and display them in solo high scores.

* Removed obsolete method from ScoreContainer
Added comments for GetBestPercentageScore()

* Update YARG.Core

* Resolved issues from PR feedback

* Tweaked "Score not saved" message
  • Loading branch information
thomeval authored Oct 23, 2024
1 parent 603dcfb commit 42c9cac
Show file tree
Hide file tree
Showing 14 changed files with 942 additions and 88 deletions.
3 changes: 3 additions & 0 deletions Assets/Art/Menu/Common/DifficultyIcons.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
221 changes: 221 additions & 0 deletions Assets/Art/Menu/Common/DifficultyIcons.png.meta

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 42c9cac

Please sign in to comment.