Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] refresh token 기반 토큰 재발급 #123

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

[feat] refresh token 기반 토큰 재발급 #123

wants to merge 1 commit into from

Conversation

hwookim
Copy link
Collaborator

@hwookim hwookim commented Feb 13, 2023

close #116

💡 개요

  • 토큰 기간 만료 시 재발급

📝 작업 내용

  • 재발급 api 호출 구현
  • response에서 code가 2002(코드 만료)일 때 재발급하도록 변경

‼️ 주의 사항

  • 이슈에 적은 대로 토큰이 완전히 만료되어 유효하지 않을 때 어떻게 처리해야할지 방법이 잘 생각나질 않습니다 😢
  • 실험해볼 수 있는 환경을 어떻게 만들어야할지 몰라서,,, 일단 해당 PR은 보류하고 일요일에 모였을 때 해봐야하지 않나 싶기도 합니다.

🔗 참고자료

@hwookim hwookim added the ✨ feature 기능 개발 label Feb 13, 2023
@hwookim hwookim requested a review from KIMSEUNGGYU as a code owner February 13, 2023 13:52
@hwookim hwookim self-assigned this Feb 13, 2023
KIMSEUNGGYU
KIMSEUNGGYU reviewed Feb 14, 2023
View reviewed changes
Copy link
Collaborator

@KIMSEUNGGYU KIMSEUNGGYU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저도 이부분 고민했었는데 이번주에 만날때 한 번 논의해봐요!
저도 방법 고민해보겠습니다~

@KIMSEUNGGYU KIMSEUNGGYU mentioned this pull request Feb 14, 2023
Closed
@hwookim hwookim marked this pull request as draft February 14, 2023 14:21
@hwookim hwookim mentioned this pull request Feb 24, 2023
Merged
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KIMSEUNGGYU KIMSEUNGGYU KIMSEUNGGYU left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@hwookim hwookim

Labels
✨ feature 기능 개발
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat] access-token 만료시 refresh-token 기반으로 재발급받기
2 participants
@hwookim @KIMSEUNGGYU