upgrade package common #768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gzliudan
force-pushed
the
upgrade_common
branch
from
2ff92e6 to
b6f54b9
Compare
gzliudan
requested review from
wjrjerome,
liam-lai,
wgr523,
wanwiset25 and
benjamin202410
gzliudan
force-pushed
the
upgrade_common
branch
2 times, most recently
from
7d0a6cf to
4fe9a2a
Compare
benjamin202410
approved these changes
Dec 27, 2024
…ion (ethereum#19846) Gollvm has very aggressive dead code elimination that completely removes one of these two benchmarks. To prevent this, use the result of the benchmark (a boolean), and to be "fair", make the transformation to both benchmarks. To be reliably assured of not removing the code, "use" means assigning to an exported global. Non-exported globals and //go:noinline functions are possibly subject to this optimization.
complier/solidity:add json.Unmarshal err check
Many of the other types have a function to convert the type to a big.Int, but Address was missing this function. It is useful to be able to turn an Address into a big.Int when doing EVM-like computations natively in Go. Sometimes a Solidity address type is casted to a uint256 and having a Big method on the Address type makes this easy.
common,p2p: remove unused function MakeName
* beacon/types: add beacon chain data types * beacon/merkle: added comments * go.mod: cleanups --------- Co-authored-by: Péter Szilágyi <[email protected]>
common/math: does not change base parameter
…m#29078) fixes some links in documentation
Co-authored-by: Felix Lange <[email protected]>
* chore: rename variable name `int` to `in` * chore: rename variable name `int` to `n`
…#30014) Co-authored-by: Martin Holst Swende <[email protected]>
Since Decimal is defined as unsiged `uint64`, we should use `strconv.ParseUint` instead of `strconv.ParseInt` during unmarshalling. --------- Co-authored-by: Martin Holst Swende <[email protected]>
gzliudan
force-pushed
the
upgrade_common
branch
from
4fe9a2a to
6e33633
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR picks the following PRs about the package
commonfrom geth:abigen --pkgflag with standard input ethereum/go-ethereum#19207EncodeBig(...)ethereum/go-ethereum#23780Address.Bigethereum/go-ethereum#26132inttoinethereum/go-ethereum#29890ParseUintinstead ofParseIntethereum/go-ethereum#30020Types of changes
What types of changes does your code introduce to XDC network?
Put an
✅in the boxes that applyImpacted Components
Which part of the codebase this PR will touch base on,
Put an
✅in the boxes that applyChecklist
Put an
✅in the boxes once you have confirmed below actions (or provide reasons on not doing so) that