Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

after we use time.Ticker it didn't allow to have 0 time duration #493

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

liam-lai
Copy link
Collaborator

@liam-lai liam-lai commented Mar 15, 2024

Proposed changes

Related to #400
After we use time.Ticker it didn't allow to have 0 time duration. When we call eth_getLogs it panics and crash the nodes, change to non 0 will resolve this issue

Thanks @gzliudan for finding the root cause.

Error Log:
2024-03-15 18 54 56

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A
    Too complicate to write unit test, will do the test on devnet while calling eth_getLogs api.

@liam-lai liam-lai merged commit bbab326 into dev-upgrade Mar 15, 2024
32 checks passed
@liam-lai liam-lai deleted the fix-panic branch March 15, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants