Merge pull request #754 from gzliudan/use_replace_all

all: replace strings.Replace with string.ReplaceAll
XinFinOrg · Dec 8, 2024 · b0ec104 · b0ec104
2 parents fee2577 + 02a59e8
commit b0ec104
Show file tree

Hide file tree

Showing 6 changed files with 17 additions and 17 deletions.
diff --git a/accounts/abi/bind/bind.go b/accounts/abi/bind/bind.go
@@ -117,7 +117,7 @@ func Bind(types []string, abis []string, bytecodes []string, pkg string, lang La
 		}
 		contracts[types[i]] = &tmplContract{
 			Type:        capitalise(types[i]),
-			InputABI:    strings.Replace(strippedABI, "\"", "\\\"", -1),
+			InputABI:    strings.ReplaceAll(strippedABI, "\"", "\\\""),
 			InputBin:    strings.TrimSpace(bytecodes[i]),
 			Constructor: evmABI.Constructor,
 			Calls:       calls,

diff --git a/cmd/faucet/website.go b/cmd/faucet/website.go
diff --git a/eth/tracers/internal/tracers/assets.go b/eth/tracers/internal/tracers/assets.go
diff --git a/ethstats/ethstats.go b/ethstats/ethstats.go
@@ -367,7 +367,7 @@ func (s *Service) readLoop(conn *connWrapper) {
 		// If the network packet is a system ping, respond to it directly
 		var ping string
 		if err := json.Unmarshal(blob, &ping); err == nil && strings.HasPrefix(ping, "primus::ping::") {
-			if err := conn.WriteJSON(strings.Replace(ping, "ping", "pong", -1)); err != nil {
+			if err := conn.WriteJSON(strings.ReplaceAll(ping, "ping", "pong")); err != nil {
 				log.Warn("Failed to respond to system ping message", "err", err)
 				return
 			}

diff --git a/internal/jsre/deps/bindata.go b/internal/jsre/deps/bindata.go
diff --git a/p2p/nat/natupnp_test.go b/p2p/nat/natupnp_test.go
@@ -218,7 +218,7 @@ func (dev *fakeIGD) ServeHTTP(w http.ResponseWriter, r *http.Request) {
 }
 
 func (dev *fakeIGD) replaceListenAddr(resp string) string {
-	return strings.Replace(resp, "{{listenAddr}}", dev.listener.Addr().String(), -1)
+	return strings.ReplaceAll(resp, "{{listenAddr}}", dev.listener.Addr().String())
 }
 
 func (dev *fakeIGD) listen() (err error) {