Workflow sec fix (#120)

* fix security issue https://github.com/XinFinOrg/XDC-CSC/security/code-scanning/1
XinFinOrg · Nov 27, 2023 · 880f749 · 880f749
1 parent dff4fe2
commit 880f749
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/.github/workflows/pr_deploy.yaml b/.github/workflows/pr_deploy.yaml
@@ -6,7 +6,9 @@ on:
 
 jobs:
   build_and_deploy:
-    if: startsWith(github.head_ref, 'feature') ||  startsWith(github.head_ref, 'fix')
+    if: |
+      ( startsWith(github.head_ref, 'feature') ||  
+        startsWith(github.head_ref, 'fix') ) 
     name: Deploy on PR 
     runs-on: ubuntu-latest
     steps:
@@ -15,8 +17,10 @@ jobs:
 
       - name: check out trigger branch
         run: |
-          git fetch origin ${{ github.head_ref }}
-          git checkout ${{ github.head_ref }}
+          git fetch origin $BRANCH
+          git checkout $BRANCH
+        env:
+          BRANCH: ${{ github.head_ref }}
 
       # - name: check envs
       #   run: | 

diff --git a/.github/workflows/pr_test.yml b/.github/workflows/pr_test.yml
@@ -6,7 +6,7 @@ on:
 
 jobs:
   test_on_pr:
-    name: Test on PR
+    name: Run tests on PR
     runs-on: ubuntu-latest
     env:
       GOPATH: ${{ github.workspace }}