Amend npu build option #8619
Open
Amend npu build option #8619
+36
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create CMake variables for XRT_NPU and XRT_ALVEO in place of NPU and XRT_DKMS_ALVEO. Modify CMake files accordingly. Fix CMake file for CPack to create component specific package for single component project. This will be used for NPU builds where ultimately all but the default npu package will be disabled. Signed-off-by: Soren Soe <[email protected]>
stsoe
requested review from
rozumx,
chvamshi-xilinx and
AShivangi
as code owners
stsoe
requested review from
sonals,
maxzhen and
IshitaGhosh
and removed request for
rozumx and
AShivangi
IshitaGhosh
reviewed
Nov 23, 2024
| set (XRT_DEV_COMPONENT "xrt") | ||
|
|
||
| # For NPU builds the defalt component is "npu". | ||
| if (XRT_NPU) |
There was a problem hiding this comment.
This changes install package name to "xrt-npu". Please review whether we want to pursue it.
maxzhen
approved these changes
Nov 23, 2024
AShivangi
approved these changes
Nov 25, 2024
sonals
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Create CMake variables for XRT_NPU and XRT_ALVEO in place of NPU and XRT_DKMS_ALVEO. Modify CMake files accordingly.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
Fix CMake file for CPack to create component specific package for single component project. This will be used for NPU builds where ultimately all but the default npu package will be disabled.
How problem was solved, alternative solutions (if any) and why they were rejected
The top level build.sh script defines one of two CMake variables depending on whether
-npuis specified or not.The variables control the default CMake install component., which for
-npuwill benpuand otherwise legacyxrtcomponent. The install components created by CMake result in CPack creating packages with component names appended.Changes will have to be made to submodules built by XRT to honor any install component specified by XRT prior to including the submodule in CMake. Basically the installable pieces of a submodule can be added to any XRT component as desired. Supposedly this will be either the
npuor defaultxrtcomponent. The XRT default component is defined insrc/CMakeLists.txtin theXRT_COMPONENTCMake variable which is eithernpuorxrtdepending on build option.This PR renders #8616 obsolete.