-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix syntax errors in some pre-removal and post-installation scripts #8046
base: master
Are you sure you want to change the base?
Conversation
Probably the CI does not look at install script execution? |
2ff841a
to
ad7b6ee
Compare
5e3b272
to
975e5c3
Compare
OK, the problem seems worse. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me.
There is still a failing XRT test
I do not have access to the compilation logs because I cannot log into the machine (the |
975e5c3
to
ce9f767
Compare
Rebased on |
ce9f767
to
a913afd
Compare
Rebasing on |
a913afd
to
ac1f148
Compare
@keryell Can you rebase and force push? Seems like there is no way to restart CI for this old PR. |
This was introduced with commit 2b87027 from Xilinx#8008 Signed-off-by: Ronan Keryell <[email protected]>
Fix bugs introduced in commit 4747733 by Xilinx#7835 Signed-off-by: Ronan Keryell <[email protected]>
ac1f148
to
a39f7ec
Compare
The CI looks broken: it accepted some bugs in the past and trying to remove them breaks the CI??? 🤔 |
This was introduced with commit
2b87027 from
#8008