Add explicit dependency on absl for xrt_swemu abd xrt_hwemu targets #8002
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Fixes linkage of
xrt_swemu
andxrt_hwemu
targets fromruntime_src/core/pcie/emulation/
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
Mentioned components won't link on NixOS 23.11 (gcc 13.2.0, cmake 3.28.3):
claiming undefined references to abseil-cpp library.
Corresponding
CMakeFiles/xrt_[s|h]wemu.dir/link.txt
files won't mention absl either.How problem was solved, alternative solutions (if any) and why they were rejected
Explicit dependency on
absl::log
andabsl::check
was introduced into relevantCMakeLists.txt
filesI'm aware NixOS is not supported, still not sure how this even works on Ubuntu / RHEL.
Hopefully being a bit more clear re dependencies won't hurt.
Risks (if any) associated the changes in the commit
The commit was not tested on any of the officially supported distros
What has been tested and how, request additional testing if necessary
The build was only tested locally.
It is required to make sure the build passes on all the supported systems.
Documentation impact (if any)
None