-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
package pa'i as a flake #137
Draft
oldaccountdeadname
wants to merge
10
commits into
Xe:main
Choose a base branch
from
oldaccountdeadname:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pa'i and everything associated can now be compiled with: nix build --impure ...assuming that installed Nix version supports flakes. The `impure` is necessary as not everything down the dependency list is built with flakes, and there are some calls to `builtins.currentSystem`. Note that this currently only builds on x86_64-linux hosts.
A dev-shell can be started with `nix shell --impure`. Note that `--impure` is necessary for the same reasons as the build --- see 2c95572.
This wraps the existing script into a derivation which writes the image to $out/docker, and can be built with nix build .#docker
Pa'i and everything associated can be compiled with: nix build --impure shell.nix has been replace with Nix's inferences from the default package output. It can be accessed with: nix shell --impure docker.nix has been replaced with a *derivation* that wraps buildLayeredImage. It installs the image to $out/docker/, and can be built with: nix build .#docker --impure All of the above commands assume that the installed Nix version supports flakes. The `impure` option is necessary as not everything down the dependency list is built with flakes, and there are some impure/non-hermetic calls to `builtins.currentSystem`. Note that this currently only builds on x86_64-linux hosts. I don't have any other kernels or architectures to test with on-hand, so I can't verify build correctness for anything else --- this is *technically* the proper behavior for Flakes.
This involves: + name tests properly in the docker output + add dhall binaries to the docker output + use unstable nix in CI (to access Flakes) + build .#docker --impure instead of docker.nix
A comment was replaced with a pure evaluation causing a CI fail. This fixes that.
This slpits rustChannelOfTargets into exlpicit rustChannelOf's and passes in the sha256 required for pure evaluation.
This consists of two changes: 1. Use rustChannelOf instead of rustChannelOfTargets to supply a sha256 (required for pure eval) 2. Inherit pkgs in olin. Olin is *almost* pure, pending Xe/olin#135.
Pure evaluation is almost there. The branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi - this fork replaces the current Nix/Niv build system with Nix Flakes. Some questions that are unresolved: