Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verifiable Credentials #759

Open
wants to merge 78 commits into
base: main
Choose a base branch
from
Open

Verifiable Credentials #759

wants to merge 78 commits into from

Commits on Oct 15, 2024

  1. Update definitions.json -- generated from the tip of rippled codebase… 

    … at commit ea8e77ffec065cf1a8d1cd4517f9cebdab27cc17

Explicity specify featureCredentials inside the conf file. This enables the features inside the genesis ledger
    @ckeshava
    ckeshava committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    c7e1a15 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. Specify the CredentialCreate transaction

    @ckeshava
    ckeshava committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    9d549c1 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. Files relevant to the CredentialAccept transaction

    @ckeshava
    ckeshava committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    8375c42 View commit details
    Browse the repository at this point in the history

  2. Files pertaining to the CredentialDelete transaction 

    Refactor common elements within Credential-related transactions
    @ckeshava
    ckeshava committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    8d810fc View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Files pertaining to DepositPreauth transaction are included in this c… 

    …ommit

Deposit_preauth: array length checks on the authcreds and unauthcreds fields
    @ckeshava
    ckeshava committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    0a33121 View commit details
    Browse the repository at this point in the history

  2. FIX: Update deposit_preauth integration tests to validate the transac… 

    …tion result code
    @ckeshava
    ckeshava committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    fd8157d View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. Include account_objects RPC call to verify that cred ledger-object is… 

    … successfully deleted

Updates to Payment transaction model

Update AccountDelete transaction model with Credential ID array

Update EscrowFinish txn model with CredentialIDs

Updates to the PaymentChannelClaim txn model -- Include new unit test file
    @ckeshava
    ckeshava committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    1d85bbb View commit details
    Browse the repository at this point in the history

  2. Updates to DepositAuthorized RPC

    @ckeshava
    ckeshava committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    8ea12c4 View commit details
    Browse the repository at this point in the history

  3. address PR comments 

    Co-authored-by: Mayukha Vadari <[email protected]>
    @ckeshava @mvadari
    ckeshava and mvadari committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    e4293be View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. FIX: Use sum() method for error validation in DepositPreauth transact… 

    …ion model; Revert this file to an older version
    @ckeshava
    ckeshava committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    60b7663 View commit details
    Browse the repository at this point in the history

  2. Update the definitions.json file without changing the format of the d… 

    …ocument
    @ckeshava
    ckeshava committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    509ecd1 View commit details
    Browse the repository at this point in the history

  3. Update base_model.py -- Use mypy with Python 3.8 suggestions

    @ckeshava
    ckeshava authored Oct 22, 2024
    Configuration menu
    Copy the full SHA
    c0151c2 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. include fixAMM1_1 in the rippled.cfg file

    @ckeshava
    ckeshava committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    48b8abc View commit details
    Browse the repository at this point in the history

  2. rearrange the LedgerEntryTypes in definitions.json

    @ckeshava
    ckeshava committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    f476a51 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. include amendments which are not in majority consensus yet

    @ckeshava
    ckeshava committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    8b82c3d View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Update tests/unit/models/transactions/test_account_delete.py 

    Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
    @ckeshava @coderabbitai
    ckeshava and coderabbitai[bot] authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    a24ca5b View commit details
    Browse the repository at this point in the history

  2. Update tests/unit/models/transactions/test_credential_accept.py 

    Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
    @ckeshava @coderabbitai
    ckeshava and coderabbitai[bot] authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    4402f6d View commit details
    Browse the repository at this point in the history

  3. refactor DepositPreauth transaction validity checks

    @ckeshava
    ckeshava committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    22de7a3 View commit details
    Browse the repository at this point in the history

  4. refactor suggestions from code-rabbit

    @ckeshava
    ckeshava committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    f848bbd View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into cred

    @ckeshava
    ckeshava authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    cb63c6d View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. Update xrpl/models/transactions/deposit_preauth.py 

    Co-authored-by: Mayukha Vadari <[email protected]>
    @ckeshava @mvadari
    ckeshava and mvadari authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    ffcf1bd View commit details
    Browse the repository at this point in the history

  2. Update xrpl/models/transactions/payment_channel_claim.py 

    Co-authored-by: Mayukha Vadari <[email protected]>
    @ckeshava @mvadari
    ckeshava and mvadari authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    e498721 View commit details
    Browse the repository at this point in the history

  3. Update xrpl/models/transactions/payment_channel_claim.py 

    Co-authored-by: Mayukha Vadari <[email protected]>
    @ckeshava @mvadari
    ckeshava and mvadari authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    e5a0779 View commit details
    Browse the repository at this point in the history

  4. remove unnecessary comments

    @ckeshava
    ckeshava committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    ad4331a View commit details
    Browse the repository at this point in the history

  5. update error msg in CredentialDelete txn

    @ckeshava
    ckeshava committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    1a974fb View commit details
    Browse the repository at this point in the history

  6. Update xrpl/models/transactions/credential_accept.py 

    Co-authored-by: Mayukha Vadari <[email protected]>
    @ckeshava @mvadari
    ckeshava and mvadari authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    880a670 View commit details
    Browse the repository at this point in the history

  7. Update xrpl/models/transactions/credential_accept.py 

    Co-authored-by: Mayukha Vadari <[email protected]>
    @ckeshava @mvadari
    ckeshava and mvadari authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    af67d78 View commit details
    Browse the repository at this point in the history

  8. Update xrpl/models/transactions/credential_accept.py 

    Co-authored-by: Mayukha Vadari <[email protected]>
    @ckeshava @mvadari
    ckeshava and mvadari authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    c50d611 View commit details
    Browse the repository at this point in the history

  9. Update xrpl/models/transactions/credential_create.py 

    Co-authored-by: Mayukha Vadari <[email protected]>
    @ckeshava @mvadari
    ckeshava and mvadari authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    2c887aa View commit details
    Browse the repository at this point in the history

  10. Update xrpl/models/transactions/credential_create.py 

    Co-authored-by: Mayukha Vadari <[email protected]>
    @ckeshava @mvadari
    ckeshava and mvadari authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    8468fcd View commit details
    Browse the repository at this point in the history

  11. Update xrpl/models/transactions/credential_create.py 

    Co-authored-by: Mayukha Vadari <[email protected]>
    @ckeshava @mvadari
    ckeshava and mvadari authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    bba054d View commit details
    Browse the repository at this point in the history

  12. Update xrpl/models/transactions/credential_create.py 

    Co-authored-by: Mayukha Vadari <[email protected]>
    @ckeshava @mvadari
    ckeshava and mvadari authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    6c0b958 View commit details
    Browse the repository at this point in the history

  13. Update xrpl/models/transactions/credential_create.py 

    Co-authored-by: Mayukha Vadari <[email protected]>
    @ckeshava @mvadari
    ckeshava and mvadari authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    7f68440 View commit details
    Browse the repository at this point in the history

  14. Update xrpl/models/transactions/credential_create.py 

    Co-authored-by: Mayukha Vadari <[email protected]>
    @ckeshava @mvadari
    ckeshava and mvadari authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    1485ae9 View commit details
    Browse the repository at this point in the history

  15. Update xrpl/models/transactions/credential_accept.py 

    Co-authored-by: Mayukha Vadari <[email protected]>
    @ckeshava @mvadari
    ckeshava and mvadari authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    27f8719 View commit details
    Browse the repository at this point in the history

  16. modified the structure of error collection

    @ckeshava
    ckeshava committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    485d392 View commit details
    Browse the repository at this point in the history

  17. modified error msg in DepositPreauth txn

    @ckeshava
    ckeshava committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    562aa49 View commit details
    Browse the repository at this point in the history

  18. use _MAX_URI_LENGTH variable

    @ckeshava
    ckeshava committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    d83f0d7 View commit details
    Browse the repository at this point in the history

  19. Update all the unit tests as per the changes in model files

    @ckeshava
    ckeshava committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    a188c1a View commit details
    Browse the repository at this point in the history

  20. Use List instead of Set to store sequence of credentials

    @ckeshava
    ckeshava committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    b97d6f3 View commit details
    Browse the repository at this point in the history

  21. simplify DepositPreauth unit tests

    @ckeshava
    ckeshava committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    379620a View commit details
    Browse the repository at this point in the history

  22. unify the regex used in DIDSet and Credentials

    @ckeshava
    ckeshava committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    e63b49d View commit details
    Browse the repository at this point in the history

  23. remove the use of lambda in collecting errors

    @ckeshava
    ckeshava committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    5425b37 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. Update xrpl/models/transactions/account_delete.py 

    Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
    @ckeshava @coderabbitai
    ckeshava and coderabbitai[bot] authored Nov 1, 2024
    Configuration menu
    Copy the full SHA
    3e8b825 View commit details
    Browse the repository at this point in the history

  2. Use variables instead of magic numbers, credential length checks

    @ckeshava
    ckeshava committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    4106236 View commit details
    Browse the repository at this point in the history

  3. remove magic number in credential_delete txn model

    @ckeshava
    ckeshava committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    6e42798 View commit details
    Browse the repository at this point in the history

  4. use filter construct for deposit_preauth validity check

    @ckeshava
    ckeshava committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    0719107 View commit details
    Browse the repository at this point in the history

  5. remove doc-strings alluding to de-duplication

    @ckeshava
    ckeshava committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    f1d2b4e View commit details
    Browse the repository at this point in the history

  6. refactor credential_ids check into utils file

    @ckeshava
    ckeshava committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    bf5114a View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. Update xrpl/models/transactions/escrow_finish.py 

    Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
    @ckeshava @coderabbitai
    ckeshava and coderabbitai[bot] authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    6d8f1be View commit details
    Browse the repository at this point in the history

  2. address PR comments from Mayukha

    @ckeshava
    ckeshava committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    8e496e1 View commit details
    Browse the repository at this point in the history

  3. Update tests/integration/transactions/test_credential.py 

    Co-authored-by: Mayukha Vadari <[email protected]>
    @ckeshava @mvadari
    ckeshava and mvadari authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    5656080 View commit details
    Browse the repository at this point in the history

  4. Update xrpl/models/utils.py 

    Co-authored-by: Mayukha Vadari <[email protected]>
    @ckeshava @mvadari
    ckeshava and mvadari authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    b43aa12 View commit details
    Browse the repository at this point in the history

  5. Update xrpl/models/transactions/credential_create.py 

    Co-authored-by: Mayukha Vadari <[email protected]>
    @ckeshava @mvadari
    ckeshava and mvadari authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    6392351 View commit details
    Browse the repository at this point in the history

  6. Update xrpl/models/transactions/credential_delete.py 

    Co-authored-by: Mayukha Vadari <[email protected]>
    @ckeshava @mvadari
    ckeshava and mvadari authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    4ad028b View commit details
    Browse the repository at this point in the history

  7. Update xrpl/models/transactions/deposit_preauth.py 

    Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
    @ckeshava @coderabbitai
    ckeshava and coderabbitai[bot] authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    1f25b01 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into cred

    @ckeshava
    ckeshava authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    a870f2d View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. address PR comments; check for duplicates in the credential list

    @ckeshava
    ckeshava committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    a6ac0f4 View commit details
    Browse the repository at this point in the history

  2. Update xrpl/models/transactions/credential_create.py 

    Co-authored-by: Mayukha Vadari <[email protected]>
    @ckeshava @mvadari
    ckeshava and mvadari authored Nov 7, 2024
    Configuration menu
    Copy the full SHA
    111e12a View commit details
    Browse the repository at this point in the history

  3. Update xrpl/models/transactions/credential_delete.py 

    Co-authored-by: Mayukha Vadari <[email protected]>
    @ckeshava @mvadari
    ckeshava and mvadari authored Nov 7, 2024
    Configuration menu
    Copy the full SHA
    8593111 View commit details
    Browse the repository at this point in the history

  4. Update xrpl/models/transactions/credential_create.py 

    Co-authored-by: Mayukha Vadari <[email protected]>
    @ckeshava @mvadari
    ckeshava and mvadari authored Nov 7, 2024
    Configuration menu
    Copy the full SHA
    7fa47e1 View commit details
    Browse the repository at this point in the history

  5. address PR comments

    @ckeshava
    ckeshava committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    3d66a36 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. address PR comments

    @ckeshava
    ckeshava committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    2d86ea2 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2024

  1. update definitions.json to match rippled develop branch

    @ckeshava
    ckeshava committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    f58dc2c View commit details
    Browse the repository at this point in the history

  2. use short-circuit in an if-condition

    @ckeshava
    ckeshava committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    0f7f745 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. [WIP] Fix CICD integration tests

    @ckeshava
    ckeshava committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    b02f902 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into cred

    @ckeshava
    ckeshava authored Nov 12, 2024
    Configuration menu
    Copy the full SHA
    b70ac84 View commit details
    Browse the repository at this point in the history

  3. CI/CD Fix: Update docker-stop command

    @ckeshava
    ckeshava committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    7f79596 View commit details
    Browse the repository at this point in the history

  4. LedgerEntry RPC: Introduce Credential functionality

    @ckeshava
    ckeshava committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    3814a94 View commit details
    Browse the repository at this point in the history

  5. Update Contributing guidelines

    @ckeshava
    ckeshava committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    c721a87 View commit details
    Browse the repository at this point in the history

  6. fix black linter errors

    @ckeshava
    ckeshava committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    c76b755 View commit details
    Browse the repository at this point in the history

  7. fix mypy errors

    @ckeshava
    ckeshava committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    9b7d17c View commit details
    Browse the repository at this point in the history

  8. re-introduce docker health checks with server_info RPC

    @ckeshava
    ckeshava committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    5068266 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. remove extraneous comments

    @ckeshava
    ckeshava committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    c7a6e2e View commit details
    Browse the repository at this point in the history

  2. [WIP] use single docker run command

    @ckeshava
    ckeshava committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    344bb49 View commit details
    Browse the repository at this point in the history

  3. [WIP] Revert some changes to the CICD integration tests 

    update contributing instructions
    @ckeshava
    ckeshava committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    ee01fc9 View commit details
    Browse the repository at this point in the history

  4. [refactor] address Ashray PR suggestion

    @ckeshava
    ckeshava committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    09b7d18 View commit details
    Browse the repository at this point in the history

  5. update release notes in CHANGELOG

    @ckeshava
    ckeshava committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    87d2af7 View commit details
    Browse the repository at this point in the history