-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Added network error handling #159
base: main
Are you sure you want to change the base?
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/equilibriumco/xrpl-hooks-ide/98vsafFtVjQCcbukZQrBbipsEuwF |
Well, it doesn't seem to be solving the problem... If I just start the IDE locally w/o the compilation backend, I can open an example & try to compile it, but the IDE just says "Error occured while compiling!" It would be nice to see something about not being able to connect... |
OK, I'll check what that case would require :) |
Yeah, we just send generic error there, we could of course use the actual error instead but I'm not sure how "well written" it is. But anyway, compile error toasts are triggered at the end of |
Was wondering about having a centralized error handling module to parse received errors to user-readable ones, related to #82 IMO |
My console has "TypeError: NetworkError when attempting to fetch resource." - could use some editing (why TypeError?), but IMHO still better than a generic message... |
Fixes #135