Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Added network error handling #159

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

JaniAnttonen
Copy link
Collaborator

Fixes #135

@vercel
Copy link

vercel bot commented Apr 5, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/equilibriumco/xrpl-hooks-ide/98vsafFtVjQCcbukZQrBbipsEuwF
✅ Preview: https://xrpl-hooks-ide-git-feat-separate-network-errors-equilibriumco.vercel.app

@vbar
Copy link
Collaborator

vbar commented Apr 6, 2022

Well, it doesn't seem to be solving the problem... If I just start the IDE locally w/o the compilation backend, I can open an example & try to compile it, but the IDE just says "Error occured while compiling!" It would be nice to see something about not being able to connect...

@JaniAnttonen
Copy link
Collaborator Author

OK, I'll check what that case would require :)

@valstu
Copy link
Collaborator

valstu commented Apr 6, 2022

Well, it doesn't seem to be solving the problem... If I just start the IDE locally w/o the compilation backend, I can open an example & try to compile it, but the IDE just says "Error occured while compiling!" It would be nice to see something about not being able to connect...

Yeah, we just send generic error there, we could of course use the actual error instead but I'm not sure how "well written" it is. But anyway, compile error toasts are triggered at the end of compileCode.ts

@JaniAnttonen
Copy link
Collaborator Author

JaniAnttonen commented Apr 6, 2022

Yeah, we just send generic error there, we could of course use the actual error instead but I'm not sure how "well written" it is. But anyway, compile error toasts are triggered at the end of compileCode.ts

Was wondering about having a centralized error handling module to parse received errors to user-readable ones, related to #82 IMO

@vbar
Copy link
Collaborator

vbar commented Apr 6, 2022

Yeah, we just send generic error there, we could of course use the actual error instead but I'm not sure how "well written" it is.

My console has "TypeError: NetworkError when attempting to fetch resource." - could use some editing (why TypeError?), but IMHO still better than a generic message...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Network error not shown for compile failure
3 participants