Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/rb 56 check deads #38

Merged
merged 30 commits into from
Oct 3, 2023
Merged

Feature/rb 56 check deads #38

merged 30 commits into from
Oct 3, 2023

Conversation

TTENSHII
Copy link
Collaborator

@TTENSHII TTENSHII commented Oct 2, 2023 •
edited
Loading

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Norm of the code has been respected
  • In what state is your pull request?
  • Ready to merge / Waiting a reviwer to see my work.
  • Work In Progress (WIP) / My work is not finish but i want daily reviews. (Draft)
  • CI Review / I want to see what the CI thinks of my work.
  • Need feedback / Just to have feedback on what i produced. (May not be merged)
  • What kind of change does this PR introduce? (You can choose multiple)
  • Bug fix
  • Feature request
  • New / Updated documentation
  • Testing CI ( Make the pull request in draft mode)

  • What is the current behavior? (link an issue based on the kind of change this pr introduce)

  • What is the new behavior (if this is a feature change)?

  • Other information:

@TTENSHII TTENSHII requested a review from KitetsuK October 2, 2023 18:21
@TTENSHII TTENSHII requested a review from guillaumeAbel October 2, 2023 18:42
guillaumeAbel
guillaumeAbel requested changes Oct 2, 2023
View reviewed changes
src/Client/Systems/Graphic/DeathSystems.cpp Outdated Show resolved Hide resolved
src/Client/Systems/Graphic/DeathSystems.cpp Outdated Show resolved Hide resolved
src/ECS/Systems/Systems.cpp Outdated Show resolved Hide resolved
@TTENSHII TTENSHII self-assigned this Oct 3, 2023
@TTENSHII TTENSHII added the enhancement New feature or request label Oct 3, 2023
TTENSHII and others added 13 commits October 3, 2023 15:29
Saverio976
Saverio976 requested changes Oct 3, 2023
View reviewed changes
src/Client/SceneManager.cpp Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
@TTENSHII TTENSHII marked this pull request as draft October 3, 2023 19:47
@TTENSHII TTENSHII marked this pull request as ready for review October 3, 2023 20:52
Saverio976
Saverio976 approved these changes Oct 3, 2023
View reviewed changes
src/ECS/ECSCustomTypes.hpp
@@ -7,7 +7,9 @@

#pragma once

// all values are in percentage of the screen
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pourquoi supprimer ?

@Saverio976 Saverio976 merged commit 6c8c2e2 into dev Oct 3, 2023
@Saverio976 Saverio976 deleted the feature/RB-56-checkDeads branch October 10, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillaumeAbel guillaumeAbel guillaumeAbel approved these changes

@KitetsuK KitetsuK KitetsuK approved these changes

@Saverio976 Saverio976 Saverio976 approved these changes

Assignees

@TTENSHII TTENSHII

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TTENSHII @Saverio976 @KitetsuK @guillaumeAbel