ECS: Fix, reable systems to auto delete + refactor systemManager + re… #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…factor Registry custom sparseArrays MINOR
guillaumeAbel
commented
Sep 28, 2023
| @@ -31,22 +26,6 @@ static void initRaylib() | |||
| InitWindow(screenWidth, screenHeight, "R-Bus"); | |||
| SetTargetFPS(fps); | |||
| InitAudioDevice(); | |||
| Registry::getInstance().addEntity(); | |||
There was a problem hiding this comment.
this deleted code is some poc, moved in a system for more poc things like proving that system can auto delete after creating player entity.
romainpanno
reviewed
Sep 28, 2023
TTENSHII
reviewed
Sep 28, 2023
TTENSHII
approved these changes
Sep 28, 2023
PATCH
…/github.com/X-R-G-B/R-Bus into fix/RB-53-reable-systems-to-remove-themself
TTENSHII
approved these changes
Sep 28, 2023
Saverio976
requested changes
Sep 29, 2023
guillaumeAbel
commented
Sep 29, 2023
Saverio976
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…factor Registry custom sparseArrays
MINOR
What is the current behavior? (link an issue based on the kind of change this pr introduce)
What is the new behavior (if this is a feature change)?
Other information: