Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/rb 42 raylib encapsulation #30

Merged
merged 29 commits into from
Sep 28, 2023
Merged

Feature/rb 42 raylib encapsulation #30

merged 29 commits into from
Sep 28, 2023

Conversation

TTENSHII
Copy link
Collaborator

@TTENSHII TTENSHII commented Sep 27, 2023 •
edited
Loading

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Norm of the code has been respected
  • In what state is your pull request?
  • Ready to merge / Waiting a reviwer to see my work.
  • Work In Progress (WIP) / My work is not finish but i want daily reviews. (Draft)
  • CI Review / I want to see what the CI thinks of my work.
  • Need feedback / Just to have feedback on what i produced. (May not be merged)
  • What kind of change does this PR introduce? (You can choose multiple)
  • Bug fix
  • Feature request
  • New / Updated documentation
  • Testing CI ( Make the pull request in draft mode)

  • What is the current behavior? (link an issue based on the kind of change this pr introduce)

  • What is the new behavior (if this is a feature change)?
    Raylib encapsulated

  • Other information:

@TTENSHII TTENSHII self-assigned this Sep 27, 2023
@TTENSHII TTENSHII added the enhancement New feature or request label Sep 27, 2023
@TTENSHII TTENSHII marked this pull request as draft September 27, 2023 21:12
@TTENSHII TTENSHII marked this pull request as ready for review September 28, 2023 10:47
Saverio976
Saverio976 requested changes Sep 28, 2023
View reviewed changes
src/Client/EventManager/EventManager.cpp Outdated Show resolved Hide resolved
src/Client/Raylib/Audio/Audio.cpp Show resolved Hide resolved
src/Client/Raylib/Audio/Audio.hpp Outdated Show resolved Hide resolved
src/Client/Raylib/Audio/Audio.hpp Outdated Show resolved Hide resolved
src/Client/Raylib/Geometry/Geometry.cpp Outdated Show resolved Hide resolved
src/Client/Raylib/Graphics/Graphics.cpp Outdated Show resolved Hide resolved
src/Client/Raylib/Graphics/Graphics.cpp Outdated Show resolved Hide resolved
src/Client/Raylib/Graphics/Graphics.cpp Outdated Show resolved Hide resolved
src/Client/Raylib/Graphics/Graphics.cpp Outdated Show resolved Hide resolved
src/Client/Raylib/Graphics/Graphics.hpp Outdated Show resolved Hide resolved
@TTENSHII TTENSHII requested a review from Saverio976 September 28, 2023 18:41
@TTENSHII TTENSHII requested a review from Saverio976 September 28, 2023 18:53
@Saverio976 Saverio976 merged commit 8f5f564 into dev Sep 28, 2023
@Saverio976 Saverio976 deleted the feature/RB-42-Raylib-encapsulation branch October 10, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saverio976 Saverio976 Saverio976 requested changes

@guillaumeAbel guillaumeAbel guillaumeAbel approved these changes

Assignees

@TTENSHII TTENSHII

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TTENSHII @Saverio976 @guillaumeAbel