Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/rb 40 scene manager class #28

Merged
merged 14 commits into from
Sep 27, 2023
Merged

Feature/rb 40 scene manager class #28

merged 14 commits into from
Sep 27, 2023

Conversation

guillaumeAbel
Copy link
Collaborator

@guillaumeAbel guillaumeAbel commented Sep 27, 2023 •
edited
Loading

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Norm of the code has been respected
  • In what state is your pull request?
  • Ready to merge / Waiting a reviwer to see my work.
  • Work In Progress (WIP) / My work is not finish but i want daily reviews. (Draft)
  • CI Review / I want to see what the CI thinks of my work.
  • Need feedback / Just to have feedback on what i produced. (May not be merged)
  • What kind of change does this PR introduce? (You can choose multiple)
  • Bug fix
  • Feature request
  • New / Updated documentation
  • Testing CI ( Make the pull request in draft mode)

  • What is the current behavior? (link an issue based on the kind of change this pr introduce)

  • What is the new behavior (if this is a feature change)?

  • Other information:

@guillaumeAbel guillaumeAbel self-assigned this Sep 27, 2023
guillaumeAbel
guillaumeAbel commented Sep 27, 2023
View reviewed changes
src/Client/Systems/ClientSystems.cpp Outdated
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fichier séparer en dossiers Events/ et Graphic/

guillaumeAbel
guillaumeAbel commented Sep 27, 2023
View reviewed changes
src/Client/Systems/Graphic/GraphicSystems.cpp Outdated
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

des qu'on devra rajouter un system graphic on separera ce fichier en Sprite, Text, Audio etc psk il est deja bien gros

Saverio976
Saverio976 reviewed Sep 27, 2023
View reviewed changes
src/main_client.cpp Outdated Show resolved Hide resolved
@Saverio976 Saverio976 merged commit c70862e into dev Sep 27, 2023
@Saverio976 Saverio976 deleted the feature/RB-40-scene-manager-class branch October 10, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saverio976 Saverio976 Saverio976 left review comments

@TTENSHII TTENSHII Awaiting requested review from TTENSHII

Assignees

@guillaumeAbel guillaumeAbel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guillaumeAbel @Saverio976