Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MAX_MISSILE_TYPE and remove strcpy warnings #134

Closed
wants to merge 2 commits into from

Conversation

TTENSHII
Copy link
Collaborator

@TTENSHII TTENSHII commented Oct 30, 2023

PATCH

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Norm of the code has been respected
  • In what state is your pull request?
  • Ready to merge / Waiting a reviwer to see my work.
  • Work In Progress (WIP) / My work is not finish but i want daily reviews. (Draft)
  • CI Review / I want to see what the CI thinks of my work.
  • Need feedback / Just to have feedback on what i produced. (May not be merged)
  • What kind of change does this PR introduce? (You can choose multiple)
  • Bug fix
  • Feature request
  • New / Updated documentation
  • Testing CI ( Make the pull request in draft mode)
  • What is the current behavior? (link an issue based on the kind of change this pr introduce)

  • What is the new behavior (if this is a feature change)?

  • Other information:

Summary by CodeRabbit

New Features:

  • Introduced a new missile type in the game, expanding the gameplay options.

Bug Fixes:

  • Implemented a safeguard in the missile creation process to prevent the use of invalid missile types, enhancing game stability and preventing potential errors.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 30, 2023

Important

Auto Review Skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Walkthrough

The changes introduced in this commit primarily focus on enhancing the robustness of the missile creation process in the game engine. A new missile type has been added, and a check has been implemented to ensure only valid missile types are used, thereby improving the system's reliability.

Changes

File Path Summary
src/ECS/.../MessageTypes.h Introduced a new enum value MAX_MISSILE_TYPE to the missileTypes_e enum.
src/ECS/.../BulletsSystems.cpp Added a check in the createMissile function to validate the typeOfMissile parameter. If the type is not within the valid range, a std::runtime_error is thrown.

🐇🍂

As the leaves fall, so do bugs in our code,

With each commit, we lighten the load.

A missile type check, a new enum to add,

In the spirit of Halloween, let's banish the bad!

So here's to the changes, to progress we cheer,

CodeRabbit hopping forward, with nothing to fear! 🎃👻


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai help to get help.
  • @coderabbitai resolve to resolve all the CodeRabbit review comments.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.json

@TTENSHII TTENSHII marked this pull request as draft October 30, 2023 17:57
@TTENSHII TTENSHII requested a review from Saverio976 October 30, 2023 17:57
@TTENSHII TTENSHII self-assigned this Oct 30, 2023
@TTENSHII TTENSHII added the bug Something isn't working label Oct 30, 2023
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 216e9b2 and e6a12fb.
Files selected for processing (2)
  • src/ECS/MessageTypes.h (1 hunks)
  • src/ECS/Systems/BulletsSystems.cpp (1 hunks)
Files skipped from review due to trivial changes (1)
  • src/ECS/MessageTypes.h

src/ECS/Systems/BulletsSystems.cpp Show resolved Hide resolved
@TTENSHII TTENSHII changed the title CLIENT-GAME: Add MAX_MISSILE_TYPE Add MAX_MISSILE_TYPE and remove strcpy warnings Oct 30, 2023
@Saverio976
Copy link
Collaborator

#143

@Saverio976 Saverio976 closed this Nov 5, 2023
@Saverio976 Saverio976 deleted the fix/RB-158-fix-enums-Missile branch March 4, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants