NITWORK: Fix wrong comment for NOLINTBEGIN and implicit conversion 'i…

…nt' -> bool PATCH
X-R-G-B · Oct 4, 2023 · cc4fa9a · cc4fa9a
1 parent 542eca6
commit cc4fa9a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/Nitwork/ANitwork.cpp b/src/Nitwork/ANitwork.cpp
@@ -122,9 +122,9 @@ namespace Nitwork {
             startReceiveHandler();
             return;
         }
-        // NOLINT BEGIN(cppcoreguidelines-pro-type-reinterpret-cast)
+        // NOLINTBEGIN(cppcoreguidelines-pro-type-reinterpret-cast)
         auto *header = reinterpret_cast<struct header_s *>(_receiveBuffer.data());
-        // NOLINT END(cppcoreguidelines-pro-type-reinterpret-cast)
+        // NOLINTEND(cppcoreguidelines-pro-type-reinterpret-cast)
 
         if (header->magick1 != HEADER_CODE1 || header->magick2 != HEADER_CODE2) {
             std::cerr << "Error: header magick not valid" << std::endl;
@@ -163,7 +163,7 @@ namespace Nitwork {
         }
         std::reverse(ids.begin(), ids.end());
         for (std::size_t index = 0; index < _packetsSent.size(); index++) {
-            if (!ids[index]) {
+            if (ids[index] == 0) {
                 auto packet = std::find_if(_packetsSent.begin(), _packetsSent.end(), [header, index](auto &packet) {
                     return std::size_t(packet.second.id) == header.last_id_received - index;
                 });

diff --git a/src/Nitwork/NitworkServer.cpp b/src/Nitwork/NitworkServer.cpp
@@ -37,9 +37,9 @@ namespace Nitwork {
 
     void NitworkServer::handleBodyAction(const struct header_s &header, const boost::asio::ip::udp::endpoint & /* unused */)
     {
-        // NOLINTBEGIN(cppcoreguidelines-pro-type-reinterpret-cast)
+        // NOLINTBEGIN(cppcoreguidelines-pro-type-reinterpret-cast, cppcoreguidelines-pro-bounds-pointer-arithmetic)
         auto *action = reinterpret_cast<struct action_s *>(_receiveBuffer.data() + sizeof(struct header_s));
-        // NOLINTEND(cppcoreguidelines-pro-type-reinterpret-cast)
+        // NOLINTEND(cppcoreguidelines-pro-type-reinterpret-cast, cppcoreguidelines-pro-bounds-pointer-arithmetic)
         auto it = _actionsHandlers.find(action->magick);
 
         if (it == _actionsHandlers.end()) {