Merge pull request #23 from X-R-G-B/refactor/RB-43-refactor-system-ma…

…nagers-in-one Refactor/rb 43 refactor system managers in one
X-R-G-B · Sep 26, 2023 · 2b6ceb4 · 2b6ceb4
2 parents 75feba0 + 6b7deb4
commit 2b6ceb4
Show file tree

Hide file tree

Showing 28 changed files with 384 additions and 553 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -64,15 +64,13 @@ if(CLANG_TIDY_EXE)
         set_target_properties(${PROJECT_NAME_CLIENT} PROPERTIES
             VS_GLOBAL_RunCodeAnalysis true
             VS_GLOBAL_EnableClangTidyCodeAnalysis true
-            VS_GLOBAL_ClangTidyChecks "-*,clang-diagnostic-*,clang-analyzer-*,-*,clang-analyzer-*,concurrency-*,cppcoreguidelines-*,modernize-*,portability-*,readability-*,-readability-identifier-length,-modernize-use-trailing-return-type"
         )
         set_target_properties(${PROJECT_NAME_SERVER} PROPERTIES
             VS_GLOBAL_RunCodeAnalysis true
             VS_GLOBAL_EnableClangTidyCodeAnalysis true
-            VS_GLOBAL_ClangTidyChecks "-*,clang-diagnostic-*,clang-analyzer-*,-*,clang-analyzer-*,concurrency-*,cppcoreguidelines-*,modernize-*,portability-*,readability-*,-readability-identifier-length,-modernize-use-trailing-return-type"
         )
     else()
-        set(CLANG_TIDY_COMMAND "${CLANG_TIDY_EXE}" "--fix" "--fix-notes" "--fix-errors" "-header-filter=(src/ECS/)|(src/Client/)|(src/Server/)" "-checks=-*,clang-diagnostic-*,clang-analyzer-*,-*,clang-analyzer-*,concurrency-*,cppcoreguidelines-*,modernize-*,portability-*,readability-*,-readability-identifier-length,-modernize-use-trailing-return-type")
+        set(CLANG_TIDY_COMMAND "${CLANG_TIDY_EXE}" "--fix" "--fix-notes" "--fix-errors")
         set(CMAKE_CXX_CLANG_TIDY "${CLANG_TIDY_COMMAND}")
     endif()
 endif()

diff --git a/src/Client/CMakeLists.txt b/src/Client/CMakeLists.txt
@@ -13,3 +13,4 @@ target_sources(
 )
 
 add_subdirectory(Systems)
+add_subdirectory(EventManager)
diff --git a/src/ECS/EventManager/CMakeLists.txt → src/Client/EventManager/CMakeLists.txt b/src/ECS/EventManager/CMakeLists.txt → src/Client/EventManager/CMakeLists.txt
diff --git a/src/ECS/EventManager/EventManager.cpp → src/Client/EventManager/EventManager.cpp b/src/ECS/EventManager/EventManager.cpp → src/Client/EventManager/EventManager.cpp
diff --git a/src/ECS/EventManager/EventManager.hpp → src/Client/EventManager/EventManager.hpp b/src/ECS/EventManager/EventManager.hpp → src/Client/EventManager/EventManager.hpp
@@ -7,7 +7,7 @@
 
 #pragma once
 
-#include <list>
+#include <vector>
 
 class EventManager {
     public:
@@ -21,5 +21,5 @@ class EventManager {
         // NOLINTBEGIN(cppcoreguidelines-avoid-non-const-global-variables)
         static EventManager instance;
         // NOLINTEND(cppcoreguidelines-avoid-non-const-global-variables)
-        std::list<int> _activeEvents;
+        std::vector<int> _activeEvents;
 };
diff --git a/src/ECS/EventManager/Events.hpp → src/Client/EventManager/Events.hpp b/src/ECS/EventManager/Events.hpp → src/Client/EventManager/Events.hpp
@@ -8,11 +8,11 @@
 #pragma once
 
 #include <array>
-#include <list>
+#include <vector>
 #include "raylib.h"
 
 namespace Events {
-    static const auto events = {
+    static constexpr auto events = {
         KEY_LEFT,
         KEY_RIGHT,
         KEY_UP,

diff --git a/src/Client/Systems/CMakeLists.txt b/src/Client/Systems/CMakeLists.txt
@@ -11,5 +11,3 @@ target_sources(
     PRIVATE
     ${CMAKE_CURRENT_SOURCE_DIR}/ClientSystems.cpp
 )
-
-add_subdirectory(Managers)
Original file line number	Diff line number	Diff line change
Expand Up		@@ -13,3 +13,4 @@ target_sources(
		)

		add_subdirectory(Systems)
		add_subdirectory(EventManager)
-Original file line number
+Diff line change
@@ Expand Up / @@ -11,5 +11,3 @@ target_sources( @@
         PRIVATE
         ${CMAKE_CURRENT_SOURCE_DIR}/ClientSystems.cpp
     )
-    add_subdirectory(Managers)