update deps to Row. #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbnswartz
reviewed
Nov 15, 2023
…g to conventions for NT
Deploying with
|
| Latest commit: |
c6aec8e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://df887be0.read-bibleineverylanguage-org.pages.dev |
| Branch Preview URL: | https://read-dev.read-bibleineverylanguage-org.pages.dev |
PurpleGuitar
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was updating some stuff on the DOT website the other day, and being that they share a few common dependencies, I figured I should take a look at ROW and update its depedendencies. The way the localizaiton is done on the site had some breaking changes and resulted touching quite a few files (which we should really expand beyond the en/es that I started with I figure, though its not the most urgent thing ever). Here is the link to preview deploy. I poked around in both local and preview env and everything seems normal from what I can tell. (The one main thing that sometimes happens btw deploys is teh aggresive service worker caching can cause a page with no styles, in which case it needs a hard refresh).
https://read-dev.read-bibleineverylanguage-org.pages.dev/WycliffeAssociates/en_ulb?book=Gen&chapter=8
@PurpleGuitar -> You had mentioned dropping the styling around some word tags. If you'll point me an example I can add that to this PR.
@rbnswartz - tag for typical review second set of eyes on this.