Skip to content

Commit

Permalink
adjust resource idenitfier for app and add distinct player for app
Browse files Browse the repository at this point in the history
  • Loading branch information
wkelly17 committed Jan 23, 2024
1 parent 462a78a commit ff380b7
Show file tree
Hide file tree
Showing 12 changed files with 145 additions and 131 deletions.
4 changes: 2 additions & 2 deletions android/app/build.gradle
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
apply plugin: 'com.android.application'

android {
namespace "com.slbible"
namespace "com.slbible.dotapp"
compileSdkVersion rootProject.ext.compileSdkVersion
defaultConfig {
applicationId "com.slbible"
applicationId "com.slbible.dotapp"
minSdkVersion rootProject.ext.minSdkVersion
targetSdkVersion rootProject.ext.targetSdkVersion
versionCode 1
Expand Down
2 changes: 1 addition & 1 deletion android/app/src/main/java/com/slbible/MainActivity.java
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.slbible;
package com.slbible.dotapp;

import com.getcapacitor.BridgeActivity;

Expand Down
8 changes: 4 additions & 4 deletions android/app/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version='1.0' encoding='utf-8' ?>
<resources>
<string name="app_name">WA Sign Bibles</string>
<string name="title_activity_main">WA Sign Bibles</string>
<string name="package_name">com.slbible</string>
<string name="custom_url_scheme">com.slbible</string>
<string name="app_name">Sign Language Bibles</string>
<string name="title_activity_main">Sign Language Bibles</string>
<string name="package_name">com.slbible.dotapp</string>
<string name="custom_url_scheme">com.slbible.dotapp</string>
</resources>
8 changes: 7 additions & 1 deletion biome.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,13 @@
},
"files": {
"include": ["src/**/*"],
"ignore": ["node_modules", "bcApi.ts", "tests", "playwright.config.ts"]
"ignore": [
"node_modules",
"bcApi.ts",
"tests",
"playwright.config.ts",
"dotPlayer.js"
]
},
"linter": {
"enabled": true,
Expand Down
4 changes: 2 additions & 2 deletions capacitor.config.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { CapacitorConfig } from "@capacitor/cli";

const config: CapacitorConfig = {
appId: "com.slbible",
appName: "WA Sign Bibles",
appId: "com.slbible.dotapp",
appName: "Sign Language Bibles",
webDir: "dist",
server: {
androidScheme: "https",
Expand Down
4 changes: 2 additions & 2 deletions index.html
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<head>
<!-- <link href="https://vjs.zencdn.net/8.0.4/video-js.css" rel="stylesheet" /> -->
<meta charset="utf-8" />
<title>WA Sign Bibles</title>
<title>Sign Language Bibles</title>

<base href="/" />

Expand Down Expand Up @@ -33,7 +33,7 @@
<div id="root"></div>

<!-- NOTE. We are manually vendoring in the bc player the vc player. It can be in public folder bc we don't need to transform it since it's already a min file, and putting it in src folder creates a module type mismatch since it assumes a CJS or UMD env, but not module -->
<script src="/brightcove/willPlayer.js"></script>
<script src="/brightcove/dotPlayer.js"></script>
<script type="module" src="./src/main.tsx"></script>
</body>
</html>
4 changes: 2 additions & 2 deletions ios/App/App.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,7 @@
);
MARKETING_VERSION = 1.0;
OTHER_SWIFT_FLAGS = "$(inherited) \"-D\" \"COCOAPODS\" \"-DDEBUG\"";
PRODUCT_BUNDLE_IDENTIFIER = com.slbible;
PRODUCT_BUNDLE_IDENTIFIER = com.slbible.dotapp;
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_ACTIVE_COMPILATION_CONDITIONS = DEBUG;
SWIFT_VERSION = 5.0;
Expand All @@ -391,7 +391,7 @@
"@executable_path/Frameworks",
);
MARKETING_VERSION = 1.0;
PRODUCT_BUNDLE_IDENTIFIER = com.slbible;
PRODUCT_BUNDLE_IDENTIFIER = com.slbible.dotapp;
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_ACTIVE_COMPILATION_CONDITIONS = "";
SWIFT_VERSION = 5.0;
Expand Down
2 changes: 1 addition & 1 deletion ios/App/App/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<key>CFBundleDevelopmentRegion</key>
<string>en</string>
<key>CFBundleDisplayName</key>
<string>WA Sign Bibles</string>
<string>Sign Language Bibles</string>
<key>CFBundleExecutable</key>
<string>$(EXECUTABLE_NAME)</string>
<key>CFBundleIdentifier</key>
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
"vitest": "^0.34.6"
},
"lint-staged": {
"*": "biome check --apply"
"*": "biome check --apply --verbose src/**/* src/"
},
"description": "WA Sign language bibles app"
}
120 changes: 120 additions & 0 deletions public/brightcove/dotPlayer.js

Large diffs are not rendered by default.

114 changes: 0 additions & 114 deletions public/brightcove/willPlayer.js

This file was deleted.

4 changes: 3 additions & 1 deletion src/pages/Playlist.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,9 @@ function Playlist() {
<ArrowBack />
</a>
<span className="w-32 block mx-auto">
<DotLogo />
<a href="/">
<DotLogo />
</a>
</span>
{shapedPlaylist && (
<Settings
Expand Down

0 comments on commit ff380b7

Please sign in to comment.