-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React 18.2.0 #365
base: master
Are you sure you want to change the base?
React 18.2.0 #365
Conversation
NOTES: Context’s calculateChangedBits was removed or altered… not sure which.
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
Conflicts: build.yaml example/test/unmount_test.dart lib/react_client/react_interop.dart lib/react_test_utils.dart lib/src/react_client/dart2_interop_workaround_bindings.dart lib/src/react_client/private_utils.dart
@greglittlefield-wf We started getting I resolved the conflicts and pushed up a change. The tests fail but it successfully generated an asset. Hopefully this will fix our issue 🤞 edit This worked for us |
@regenvanwalbeek-wf Sorry about that! 😬 Hmm to help prevent this issue from happening again, would it be possible to load from a local |
That's how I was leaning as well - Once I have some free time I will give that a shot (hopefully by tomorrow) |
@regenvanwalbeek-wf Sounds good, let me know if we can help with anything! |
(Forgot to mention, we ended up loading from local and it worked fine https://github.com/Workiva/esg_ui/pull/2765) |
614f8f9
to
954fca9
Compare
Based on #339