Clean up unnecessary LHS types (ReactElement, final variables)

Workiva · Nov 17, 2023 · e514c58 · e514c58
1 parent 51f47d0
commit e514c58
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/test/over_react/component/_deprecated/shared_error_boundary_tests.dart b/test/over_react/component/_deprecated/shared_error_boundary_tests.dart
@@ -222,7 +222,7 @@ void sharedErrorBoundaryTests(BuilderOnlyUiFactory<ErrorBoundaryPropsMixin> buil
 
         group('when a new child is passed in', () {
           test('', () {
-            final ReactElement? newDummyChild = (Dom.div()..addTestId('newDummyChild'))('hi there');
+            final newDummyChild = (Dom.div()..addTestId('newDummyChild'))('hi there');
             jacket!.rerender((builder()
               ..addProps(ErrorBoundaryPropsMapView({})
                 ..fallbackUIRenderer = (_, __) => (Dom.div()..addTestId('fallbackNode'))('Something went wrong')

diff --git a/test/over_react/component/error_boundary/shared_error_boundary_tests.dart b/test/over_react/component/error_boundary/shared_error_boundary_tests.dart
@@ -218,7 +218,7 @@ void sharedErrorBoundaryTests(BuilderOnlyUiFactory<v2.ErrorBoundaryProps> builde
 
         group('when a new child is passed in', () {
           test('', () {
-            final ReactElement? newDummyChild = (Dom.div()..addTestId('newDummyChild'))('hi there');
+            final newDummyChild = (Dom.div()..addTestId('newDummyChild'))('hi there');
             jacket!.rerender((builder()
               ..fallbackUIRenderer = (_, __) => (Dom.div()..addTestId('fallbackNode'))('Something went wrong')
             )(newDummyChild));

diff --git a/test/over_react/component/with_transition_test.dart b/test/over_react/component/with_transition_test.dart
@@ -444,8 +444,8 @@ main() {
         });
 
         test('more than one child', () {
-          final ReactElement? child1 = Dom.div()('one');
-          final ReactElement? child2 = Dom.div()('two');
+          final child1 = Dom.div()('one');
+          final child2 = Dom.div()('two');
           expect(() => mount(WithTransition()(
             child1,
             child2,

diff --git a/test/over_react/component_declaration/component_type_checking_test.dart b/test/over_react/component_declaration/component_type_checking_test.dart
@@ -119,7 +119,7 @@ main() {
     // where auto-detecting the subtypeOf arg resulted in the UiFactory itself
     // being treated as the subtype, causing type checking to fail.
     test('works when subtyping a component whose factory hasn\'t been initialized yet', () {
-      final react_interop.ReactElement? element = function.TestUninitializedParent()();
+      final element = function.TestUninitializedParent()();
       expect(isComponentOfType(element, function.DoNotReferenceThisFactoryExceptForInASingleTest), isTrue);
       expect(isComponentOfType(element, TestAbstract2Component), isTrue);
     });