Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: row grouping algorithm #35

Merged
merged 1 commit into from
Sep 13, 2024
Merged

fix: row grouping algorithm #35

merged 1 commit into from
Sep 13, 2024

Conversation

citizensas
Copy link

fixes glideapps#823 (comment) 4th point

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10844774628

Details

  • 2 of 4 (50.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.008%) to 89.652%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/core/src/data-editor/row-grouping.ts 2 4 50.0%
Files with Coverage Reduction New Missed Lines %
packages/core/src/data-editor/row-grouping.ts 1 89.07%
Totals Coverage Status
Change from base Build 10383529118: -0.008%
Covered Lines: 17783
Relevant Lines: 19480
💛 - Coveralls

@citizensas citizensas merged commit cc64e17 into main Sep 13, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vabrahamyanadobe vabrahamyanadobe Awaiting requested review from vabrahamyanadobe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Group rows API
2 participants
@citizensas @coveralls