Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spike filter logging #106

Merged
merged 1 commit into from
Oct 16, 2023
Merged

spike filter logging #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions warp-core/src/main/scala/com/workday/warp/arbiters/ArbiterLike.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,21 @@ trait ArbiterLike extends PersistenceAware with CanReadHistory {
}

if (spikeFilterEnabled) {
logger.trace(s"voting, spike filter is enabled")
// check the last executions to see if they have a failure tag that matches
val priorExecutionHasFailureTag: Boolean = priorExecutionsFailed(testExecution, tagName, alertOnNth)
if (priorExecutionHasFailureTag) maybeFailure
if (priorExecutionHasFailureTag) {
logger.trace(s"sufficient prior consecutive failures, vote=${maybeFailure.nonEmpty}")
maybeFailure
}
// no failure tag on the last execution, (first time failure), don't vote as a failure
else None
else {
logger.trace(s"last executions did not fail, vote=false")
None
}
}
else {
logger.trace(s"spike filter is disabled, vote=${maybeFailure.nonEmpty}")
maybeFailure
}
}
Expand Down Expand Up @@ -91,9 +99,16 @@ trait ArbiterLike extends PersistenceAware with CanReadHistory {
var settings: (Boolean, Int) = this.persistenceUtils.getSpikeFilterSettings(idTestDefinition)
.map(setting => (setting.spikeFilterEnabled, setting.alertOnNth))
.getOrElse((false, 1))
logger.trace(s"base spike filter settings: $settings")
// allow individual overrides from properties if they are present
Option(WARP_ARBITER_SPIKE_FILTER_ENABLED.value).foreach(f => settings = settings.copy(_1 = f.toBoolean))
Option(WARP_ARBITER_SPIKE_FILTER_ALERT_ON_NTH.value).foreach(f => settings = settings.copy(_2 = f.toInt))
Option(WARP_ARBITER_SPIKE_FILTER_ENABLED.value).foreach { f =>
logger.trace(s"spike filter enabled override: $f")
settings = settings.copy(_1 = f.toBoolean)
}
Option(WARP_ARBITER_SPIKE_FILTER_ALERT_ON_NTH.value).foreach { f =>
logger.trace(s"spike filter alert on nth override: $f")
settings = settings.copy(_2 = f.toInt)
}
settings
}

Expand Down
5 changes: 3 additions & 2 deletions warp-core/src/main/scala/com/workday/warp/arbiters/ResponseTimeArbiter.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,9 @@ class ResponseTimeArbiter extends ArbiterLike with CorePersistenceAware {

if (threshold.isPositive && responseTime > threshold) {
Option(new RequirementViolationException(
s"$testId violated response time requirement: expected ${threshold.humanReadable} (${threshold.toMillis} ms)" +
s", but measured ${responseTime.humanReadable} (${responseTime.toMillis} ms)"
s"$testId violated response time requirement (imposed by ${this.getClass.getCanonicalName}): " +
s"expected ${threshold.humanReadable} (${threshold.toMillis} ms), " +
s"but measured ${responseTime.humanReadable} (${responseTime.toMillis} ms)"
))
}
else {
Expand Down
10 changes: 6 additions & 4 deletions warp-core/src/test/scala/com/workday/warp/arbiters/ResponseTimeArbiterSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,9 @@ class ResponseTimeArbiterSpec extends WarpJUnitSpec with CorePersistenceAware {

val vote: Option[Throwable] = arbiter.vote(ballot, testExecution)
vote should not be empty
vote.get.getMessage should be (s"$testId violated response time requirement: expected 0:00:03.000 (3000 ms), but " +
"measured 0:00:04.000 (4000 ms)")
vote.get.getMessage should be (s"$testId violated response time requirement" +
" (imposed by com.workday.warp.arbiters.ResponseTimeArbiter):" +
" expected 0:00:03.000 (3000 ms), but measured 0:00:04.000 (4000 ms)")
}


Expand All @@ -68,7 +69,8 @@ class ResponseTimeArbiterSpec extends WarpJUnitSpec with CorePersistenceAware {

val vote: Option[Throwable] = arbiter.vote(ballot, testExecution)
vote should not be empty
vote.get.getMessage should be (s"$testId violated response time requirement: expected 0:00:03.000 (3000 ms), but " +
"measured 0:00:04.000 (4000 ms)")
vote.get.getMessage should be (s"$testId violated response time requirement" +
" (imposed by com.workday.warp.arbiters.ResponseTimeArbiter):" +
" expected 0:00:03.000 (3000 ms), but measured 0:00:04.000 (4000 ms)")
}
}