Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add Storybook and Chromatic #43

Merged
merged 2 commits into from
Oct 18, 2023
Merged

chore: Add Storybook and Chromatic #43

merged 2 commits into from
Oct 18, 2023

Conversation

alanbsmith
Copy link
Member

@alanbsmith alanbsmith commented Oct 12, 2023 •
edited
Loading

Issue

Resolves #1 and #2

Summary

This PR adds:

  • initial @workday/canvas-tokens-docs package
  • Storybook setup
  • Visual tests for @workday/canvas-tokens-web tokens
  • initial Getting Started documentation
  • pull-request automation

Release Category

Documentation

Where Should the Reviewer Start?

packages/canvas-tokens-docs/stories/

Testing Manually

Thank You GIF

This will definitely all fit into one PR, right?
a cat trying to fit in a very small glass bowl

@alanbsmith alanbsmith force-pushed the ISSUE-1 branch 15 times, most recently from 801fc1c to 0268bfe Compare October 18, 2023 06:01
@alanbsmith alanbsmith added the automerge Automatically merge pull request label Oct 18, 2023
@alanbsmith alanbsmith changed the title chore: Add Storybook chore: Add Storybook and Chromatic Oct 18, 2023
RayRedGoose
RayRedGoose reviewed Oct 18, 2023
View reviewed changes
Copy link
Contributor

@RayRedGoose RayRedGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have small suggestion, but otherwise it looks good for me 🙂

packages/canvas-tokens-docs/stories/brand/examples/Color.tsx Outdated Show resolved Hide resolved
RayRedGoose
RayRedGoose approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@RayRedGoose RayRedGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@alanbsmith alanbsmith removed the automerge Automatically merge pull request label Oct 18, 2023
@alanbsmith alanbsmith added the automerge Automatically merge pull request label Oct 18, 2023
@alanbsmith alanbsmith merged commit 2569e0d into Workday:main Oct 18, 2023
6 checks passed
@alanbsmith alanbsmith deleted the ISSUE-1 branch October 18, 2023 18:02
@alanbsmith alanbsmith mentioned this pull request Oct 19, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RayRedGoose RayRedGoose RayRedGoose approved these changes

Assignees
No one assigned
Labels
automerge Automatically merge pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Storybook
2 participants
@alanbsmith @RayRedGoose