Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(web): Fix the common-js module path #20

Merged
merged 1 commit into from
Sep 20, 2023
Merged

fix(web): Fix the common-js module path #20

merged 1 commit into from
Sep 20, 2023

Conversation

NicholasBoll
Copy link
Member

@NicholasBoll NicholasBoll commented Sep 20, 2023 •
edited by RayRedGoose
Loading

Issue

Fixes #19

Summary

Jest tests do not work because Jest uses commonjs module resolution. The package.json references "commonjs" while the directory is "common-js"

Release Category

Web Infrastructure

@RayRedGoose RayRedGoose changed the title fix(web): Fix the common-js module path chore: Fix the common-js module path Sep 20, 2023
@RayRedGoose RayRedGoose changed the title chore: Fix the common-js module path fix(web): Fix the common-js module path Sep 20, 2023
@RayRedGoose RayRedGoose added the automerge Automatically merge pull request label Sep 20, 2023
@alanbsmith alanbsmith merged commit 199765a into main Sep 20, 2023
8 checks passed
@alanbsmith alanbsmith deleted the fix/common-js branch October 19, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RayRedGoose RayRedGoose RayRedGoose approved these changes

@mannycarrera4 mannycarrera4 mannycarrera4 approved these changes

Assignees
No one assigned
Labels
automerge Automatically merge pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The commonjs path is incorrect
4 participants
@NicholasBoll @mannycarrera4 @RayRedGoose @alanbsmith