Skip to content

Commit

Permalink
fix: Review updates
Browse files Browse the repository at this point in the history
  • Loading branch information
alanbsmith committed Oct 9, 2023
1 parent 25cb7a9 commit 53c3484
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 37 deletions.
42 changes: 7 additions & 35 deletions .github/workflows/pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,28 +8,10 @@ jobs:

steps:
- uses: actions/checkout@v3
## This step installs node and sets up several matchers (regex matching for Github Annotations). See
## https://github.com/actions/setup-node/blob/25316bbc1f10ac9d8798711f44914b1cf3c4e954/src/main.ts#L58-L65
- uses: actions/setup-node@v3
with:
node-version: 16.x
registry-url: https://registry.npmjs.org

## The caching steps create a cache key based on the OS and hash of the package-json.lock file.
## A cache hit will copy files from Github cache into the `node_modules` folder.
## A cache hit will skip the cache steps.
- name: Cache node modules
id: npm-cache
uses: actions/cache@v3
- uses: Workday/canvas-kit-actions/install@v1
with:
path: node_modules
key: ${{ runner.os }}-16.x-node-modules-hash-${{ hashFiles('package-lock.json') }}

## If `node_modules` has a cache hit, we're going to skip the `npm install` step.
- name: Install Packages
if: steps.npm-cache.outputs.cache-hit != 'true'
shell: bash
run: npm install --production=false
node_version: 16.x

check:
runs-on: ubuntu-latest
Expand All @@ -38,21 +20,11 @@ jobs:
steps:
- uses: actions/checkout@v3

## The caching steps create a cache key based on the OS and hash of the package-json.lock file.
## A cache hit will copy files from Github cache into the `node_modules` folder.
## A cache hit will skip the cache steps.
- name: Cache node modules
id: npm-cache
uses: actions/cache@v3
- uses: Workday/canvas-kit-actions/install@v1
with:
path: node_modules
key: ${{ runner.os }}-16.x-node-modules-hash-${{ hashFiles('package-lock.json') }}

- name: Install Packages
if: steps.npm-cache.outputs.cache-hit != 'true'
shell: bash
run: npm install --production=false

node_version: 16.x

# Keep steps separate for Github Actions annotation matching: https://github.com/actions/setup-node/blob/83c9f7a7df54d6b57455f7c57ac414f2ae5fb8de/src/setup-node.ts#L26-L33
- name: Lint
shell: bash
run: yarn lint
Expand All @@ -63,4 +35,4 @@ jobs:

- name: Run Unit Tests
shell: bash
run: npm test
run: yarn test
2 changes: 1 addition & 1 deletion .github/workflows/release-web.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:

- uses: Workday/canvas-kit-actions/install@v1
with:
node_version: 18.x
node_version: 16.x

- name: Config git user
shell: bash
Expand Down
2 changes: 1 addition & 1 deletion MAINTAINING.md
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ We use [Jest](https://jestjs.io/docs/getting-started) to unit test internal logi
tests locally:

```sh
npm test
yarn test
```

## Publishing

0 comments on commit 53c3484

Please sign in to comment.