docs: Add new examples of new AriaLiveRegion component #2672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 22 commits
February 12, 2024 15:46
Making smaller components for MyTasksLiveBadge and NotificationsBadge.
Focus more on the live badges of the icon buttons. GlobalHeader is just a distraction.
On the 2 different versions of live badges.
Also removed the icon buttons with live badges from the storybook.
williamjstanton
commented
Apr 2, 2024
|
|
||
| return ( | ||
| <> | ||
| <Flex padding={space.s} gap={space.s} as="header"> |
There was a problem hiding this comment.
I was researching 3 different ways to build an icon button using Badges and live regions. I wasn't completely satisfied with any of my results, if I am honest. I didn't exactly want to throw the research away, but I didn't want to necessarily include the example in Storybook until I had something I was happy with.
Passing run #7160 ↗︎
Details:
Review all test suite changes for PR #2672 ↗︎ |
|||||||||||||||
jaclynjessup
added
ready for review
RayRedGoose
previously approved these changes
Apr 9, 2024
modules/react/_examples/stories/examples/common/FilterListWithLiveStatus.tsx
Outdated
Show resolved
Hide resolved
modules/react/_examples/stories/examples/common/FilterListWithLiveStatus.tsx
Outdated
Show resolved
Hide resolved
modules/react/_examples/stories/examples/common/FilterListWithLiveStatus.tsx
Outdated
Show resolved
Hide resolved
modules/react/_examples/stories/examples/common/FilterListWithLiveStatus.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Raisa Primerova <[email protected]>
Co-authored-by: Raisa Primerova <[email protected]>
Co-authored-by: Raisa Primerova <[email protected]>
NicholasBoll
changed the title
NicholasBoll
approved these changes
Apr 12, 2024
NicholasBoll
added
automerge
and removed
ready for review
RayRedGoose
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With the release of the new
AriaLiveRegioncomponent, I wanted to build a few simple examples to introduce to developers what an ARIA live region is, and how they can be used to positively impact the accessible experience with screen readers.Release Category
Documentation
Checklist
ready for reviewhas been added to PRFor the Reviewer
Where Should the Reviewer Start?
For now, I have created an
AriaLiveRegioncategory in the Examples section of Storybook. I have 4 examples: A visible live region, a hidden live region, a filterable list with a live status, and an input field with a live inline error.Areas for Feedback? (optional)