Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make site metadata accessible #266

Merged
merged 4 commits into from
Jan 8, 2024
Merged

Conversation

adamwoodnz
Copy link
Contributor

@adamwoodnz adamwoodnz commented Jan 5, 2024

Fixes #235

After trying various CSS display layouts (flex, grid, table) and failing to make the content display well and read well, this PR updates the markup to use a table so that screen reader users can use appropriate content navigation.

This is the approach suggested by the A11y team.

There should be no visual change.

Screenshots

Home

Desktop Tablet Mobile
localhost_8888_(Desktop) (2) localhost_8888_(iPad) localhost_8888_(Galaxy S5)

Single

Desktop Tablet Mobile
localhost_8888_vogue_(Desktop) localhost_8888_vogue_(iPad) localhost_8888_vogue_(Galaxy S5)

NVDA transcripts

Home page

main landmark    list  with 1 item  table  with 3 rows and 2 columns  row 1  column 1  Site title
column 2  visited  link    Vogue
URL  row 2  link    vogue.com
Category  row 3  link    Publication

Single site page

main landmark    table  with 4 rows and 2 columns  row 1  column 1  Author
column 2  Condé Nast
Country  row 2  United States
Category  row 3  link    Publication
Published  row 4  October 2019

Testing

Browse the home page and single site pages using a screen reader, preferably JAWS or NVDA.
Focus the table using t then Ctrl+Alt+Arrows to navigate within the table.
Content should be read out with semantics as above.
Check for visual regressions, including various screen sizes and RTL.

@adamwoodnz adamwoodnz added [Component] Blocks/Editor Custom blocks, block variations, or editor customization Accessibility Issues related to keyboard navigation, screen readers, etc labels Jan 5, 2024
@adamwoodnz adamwoodnz self-assigned this Jan 5, 2024
@adamwoodnz adamwoodnz force-pushed the fix/235-metadata-accessibility branch from d86c8e2 to a3629da Compare January 5, 2024 02:51
@adamwoodnz adamwoodnz added this to the Future milestone Jan 5, 2024
@adamwoodnz adamwoodnz added [Component] Theme Templates, patterns, CSS and removed [Component] Blocks/Editor Custom blocks, block variations, or editor customization labels Jan 5, 2024
@adamwoodnz adamwoodnz marked this pull request as ready for review January 5, 2024 03:37
@adamwoodnz adamwoodnz changed the title Use a table for site metadata Make site metadata accessible Jan 5, 2024
@adamwoodnz adamwoodnz force-pushed the fix/235-metadata-accessibility branch from 944f0d8 to 9223ee3 Compare January 8, 2024 01:05
@adamwoodnz adamwoodnz force-pushed the fix/235-metadata-accessibility branch from 9223ee3 to a57d681 Compare January 8, 2024 01:08
@adamwoodnz adamwoodnz merged commit a8a1b3d into main Jan 8, 2024
1 check passed
@adamwoodnz adamwoodnz deleted the fix/235-metadata-accessibility branch January 8, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Issues related to keyboard navigation, screen readers, etc [Component] Theme Templates, patterns, CSS
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Accessibility improvements for the Site metadata table
1 participant