-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Submission: Fix messed up thanks you screen dot pattern #227
Conversation
Thanks @adamwoodnz! Nice catch. Hi @marko-srb 👋 Can you help trim the image you provided in the ticket? Just trim the top, bottom, and left margins, leaving the right margin intact. This is the original broken image. It appears normal when applied with repeat-x, so the right margin's whitespace needs to be preserved. |
I see this is solved, and I see dot exports in Figma. In case you still need my help, let me know. Thanks! |
Update Screencast dark.dots.movHere are some notes from my discussion with @jasmussen : Joen mentioned if we can have the image align with the text on both sides. However, since the image is positioned at center/right/left and then repeat-x, there will still be some gaps. For instance, when positioned at center, the image will repeat left and right until it can no longer repeat, naturally creating some small gaps.
While positioning it to the left would always align it with "Home", but as it repeats to the right, it creates a larger gap near "View All Sites", which can make the layout look a bit odd at certain screen sizes. Center positioning seems to be a better option in this scenario.
Also added a TODO in the PR description, I guess we need to change the dot pattern on other pages accordingly? |
I think this can work. Just to wrap the concept, here's an alternative that I think could also work: https://codepen.io/joen/pen/BavbKQJ?editors=1100 — horizontally tiling. |
Looks good. If you can add or 4px margin or padding on the left, that'd be good, the dots almost line up with News but not quite. Thanks for keeping on this. |
Oh, you're right! It was an optical imbalance on my part. They are indeed lined up. Thank you for the attention to detail, ship it. |
Fixes #224
TODO (Maybe)