Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submission: Fix messed up thanks you screen dot pattern #227

Merged
merged 3 commits into from
Oct 12, 2023

Conversation

renintw
Copy link
Contributor

@renintw renintw commented Oct 6, 2023

Fixes #224

image

TODO (Maybe)

@renintw renintw self-assigned this Oct 6, 2023
@adamwoodnz
Copy link
Contributor

adamwoodnz commented Oct 8, 2023

There's an issue with the image not repeating properly, see the double dots in your screenshot and here's a close up:

It's visible on the right and left above ~1330px wide. This isn't happening on main so I'm guessing the image crop has changed slightly.

@renintw
Copy link
Contributor Author

renintw commented Oct 9, 2023

Thanks @adamwoodnz! Nice catch.

Hi @marko-srb 👋

Can you help trim the image you provided in the ticket? Just trim the top, bottom, and left margins, leaving the right margin intact.
image

This is the original broken image. It appears normal when applied with repeat-x, so the right margin's whitespace needs to be preserved.
image

@marko-srb
Copy link

I see this is solved, and I see dot exports in Figma.

In case you still need my help, let me know. Thanks!

@renintw
Copy link
Contributor Author

renintw commented Oct 10, 2023

Update Screencast

dark.dots.mov

Here are some notes from my discussion with @jasmussen :

Joen mentioned if we can have the image align with the text on both sides. However, since the image is positioned at center/right/left and then repeat-x, there will still be some gaps.

For instance, when positioned at center, the image will repeat left and right until it can no longer repeat, naturally creating some small gaps.

Left Right
image image

While positioning it to the left would always align it with "Home", but as it repeats to the right, it creates a larger gap near "View All Sites", which can make the layout look a bit odd at certain screen sizes. Center positioning seems to be a better option in this scenario.

Bigger Gap on the right side Look weird overall on certain screen sizes
image image

Also added a TODO in the PR description, I guess we need to change the dot pattern on other pages accordingly?

@renintw renintw requested a review from jasmussen October 10, 2023 16:48
@jasmussen
Copy link

I think this can work.

Just to wrap the concept, here's an alternative that I think could also work: https://codepen.io/joen/pen/BavbKQJ?editors=1100 — horizontally tiling.

@renintw
Copy link
Contributor Author

renintw commented Oct 11, 2023

Horizontally Tiling

Submit Page (Black Dots) Login Page (Blue Dots) Thank you Page
submit page black dots submit page (non-login, blue dots) thanks page

If it looks great, I'll merge it as is.

@renintw renintw added this to the Launch milestone Oct 11, 2023
@jasmussen
Copy link

Looks good. If you can add or 4px margin or padding on the left, that'd be good, the dots almost line up with News but not quite. Thanks for keeping on this.

@renintw
Copy link
Contributor Author

renintw commented Oct 12, 2023

image

Is this the line you're referring to, it seems already lined up. I might've mistaken the context, though.

@jasmussen
Copy link

Oh, you're right! It was an optical imbalance on my part. They are indeed lined up. Thank you for the attention to detail, ship it.

@renintw renintw merged commit c94ff2e into main Oct 12, 2023
1 check passed
@renintw renintw deleted the fix/Thank-you-screen-dot-pattern branch October 12, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Thank you screen / Dot pattern
4 participants