Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add related sites to single site pages #149

Merged
merged 4 commits into from
Sep 14, 2023
Merged

Add related sites to single site pages #149

merged 4 commits into from
Sep 14, 2023

Conversation

ryelle
Copy link
Contributor

@ryelle ryelle commented Sep 13, 2023

Fixes #140 — This adds the related sites section to single site pages. It uses Jetpack's related posts feature, but overrides the output to render using the theme's blocks. It also adds some fallback posts to make sure there are always 3 results in the related section.

Design Branch

@WordPress/meta-design The heading font size (for "Related sites") uses the "heading 5" font size, which is 26px on large screens, but breaks to 20px on small. In figma, it's 26 across both sizes, is that intentional? Should I set this to a custom 26px instead?

To test:

This needs to be tested on a live site, like the staging site, so use your sandbox. This is because Jetpack's related posts does not work in dev/offline mode.

@ryelle ryelle added the [Component] Theme Templates, patterns, CSS label Sep 13, 2023
@ryelle ryelle requested review from adamwoodnz, StevenDufresne and a team September 13, 2023 19:43
@ryelle ryelle self-assigned this Sep 13, 2023
Copy link
Collaborator

@StevenDufresne StevenDufresne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my sandbox. Looks good!

@jasmussen
Copy link

Nice, very close. There's a small thing with the text and tags not lining up:
267767574-e27151e8-48c1-4641-8994-65b6de1919fb

It's probably a line-height that is affected by whether tags are present or not.

@ryelle
Copy link
Contributor Author

ryelle commented Sep 14, 2023

Alignment updated:

Screenshot 2023-09-14 at 1 38 57 PM

@ryelle ryelle merged commit 28a1380 into main Sep 14, 2023
1 check passed
@ryelle ryelle deleted the add/related-posts branch September 14, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Theme Templates, patterns, CSS
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Related sites on single sites
3 participants