-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility improvements for the Site metadata table #235
Comments
It appears that flex is causing this. I think that's the best layout technique, so I'll investigate ways to create a better reading experience. |
My first attempt at using an |
V2 didn't work as link elements were duplicated in the tab order. Starting V3 with absolute positioning of labels to avoid the nested elements required for the flex layout. |
I am reopening, given this comment. Thanks for all your hard work on this @adamwoodnz. |
Don’t we already have this working on tutorials single page? Let me know if we can replicate solution done there? CC: @adamwoodnz , @ndiego Thank you! |
https://learn.wordpress.org/tutorial/the-wordpress-database/ Additional example, with more than one item / link... |
If the design in the above examples exhibits the same problem. Then we might consider this a post-launch item where we update all instances of the same design pattern across WordPress.org. |
You're correct that the original layout is very similar to the Learn examples linked, eg. https://learn.wordpress.org/tutorial/custom-database-tables/ The NVDA transcript reads like this for me:
Very similar to how the Showcase list is read. @alexstine is the Learn meta list also problematic for you? |
@adamwoodnz Yes, it is also a problem. 😞 |
Darn, but I am glad we caught it. I am going to remove this issue from the launch milestone, but let's explore a holistic solution to this design pattern and then update both. |
Visually, this is a table; it's presented as two columns of data, with the left column as table headers and the right column data cells. Is there any reason this can't use the same semantics that it presents visually? |
@joedolson I agree, this is essentially where @alexstine and I ended up too |
I've now converted this to a table as discussed. @alexstine and @joedolson please try it out when you have a chance, and reopen if any issues 🙏 |
Should probably define the |
Copied from WordPress Slack: https://wordpress.slack.com/archives/C04U953K77A/p1696899077421269?thread_ts=1696525287.393319&cid=C04U953K77A
On screenreaders, the content in the Site metadata table is not being read well. What could we do to improve this?
The text was updated successfully, but these errors were encountered: