Add tag name configurability to global footer block #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwoodnz
added
the
Accessibility
ryelle
reviewed
Jun 5, 2024
| @@ -847,8 +847,10 @@ function render_global_footer( $attributes, $content, $block ) { | |||
| $wrapper_attributes = get_block_wrapper_attributes( | |||
| array( 'class' => 'global-footer wp-block-group' ) | |||
| ); | |||
| $tag_name = $attributes['tagName'] ?? 'footer'; | |||
There was a problem hiding this comment.
Do you think this should be validated somehow, maybe one of a list of possible tag names? I guess it would just be div or footer, in reality.
There was a problem hiding this comment.
Yeah that's a good idea imo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See WordPress/Learn#2501 and https://wordpress.slack.com/archives/C01KC5VDQBC/p1717552327365119?thread_ts=1717455021.461299&cid=C01KC5VDQBC
On Learn there is a site footer above the global footer. This is currently between the
mainand thefooterlandmark provided by the global footer block. For accessibility reasons there shouldn't be content between these landmarks.This PR adds the ability for the tagName to be configured so that the global footer can be nested within a footer element and maintain valid HTML.
Can be tested using WordPress/Learn#2502
There should be no effect in other themes as the default value for the
tagNameattribute is set tofooter.Before
After