Google Map: Throttle filtering handler to improve performance #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can take 5 or more map re-renders and condense it down to 1, without a noticible effect on responsiveness to the user. See https://www.developerway.com/posts/debouncing-in-react
iandunn
force-pushed
the
map-debounce-search
branch
from
8a1757b to
ea7dc3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #435
This can take 5 or more map re-renders and condense it down to 1, without a noticible effect on responsiveness to the user.
See https://www.developerway.com/posts/debouncing-in-react for the technique I used to make it work across React renders.
I tried debouncing and throttling, but throttling seemed best. With debouncing the handler would often receive the first letter of a search and redraw the map based on that, even though that's not very useful. With throttling it often gets 3-5 characters for the first re-draw, but it still feels faster than waiting on the first debounce.