Query filters: Add taxonomy to apply button of query filter block #469
Conversation
renintw
added
[Block] Query Filter
[Type] Enhancement
renintw
requested review from
adamwoodnz,
jasmussen,
StevenDufresne and
ndiego
renintw
force-pushed
the
enhance/add-taxonomy-text
branch
from
bf08c8d to
21453fe
Compare
renintw
changed the title
There was a problem hiding this comment.
Great start, there are a few grammatical issues with this though, regarding singular and plural states 🙂
Screenshots
| 2 tags | 1 flavor |
|---|---|
 |
 |
'Apply (2) popular' doesn't make complete sense without 'tag'. I think we could actually drop the brackets to make the language more natural too. Suggest it should read 'Apply 1 popular tag' if singular, and 'Apply 2 popular tags' if plural.
'Apply (1) flavors' should read 'Apply 1 flavor' if singular, and 'Apply 2 flavors' if plural.
@WordPress/meta-design thoughts please?
👍 Fixed
I don't have a strong preference for the brackets. I've pushed the commit and included a screenshot here for reference.
|
👍 Updated in 5d6b80d 
|
|
Note: Based on the discussion in the ticket, this PR might not be needed anymore. |
|
I'll defer to @ndiego and @StevenDufresne on this one! |
renintw
added
the
[Status] In Discussion
|
Drop GIFs here for better decision-making.
|
|
Thanks for all your hard work here @renintw. Let's stick with WordPress/wporg-showcase-2022#228 for now, and pending any additional user feedback, we could add this PR as well. But hopefully, the term counts is enough. |
Closes WordPress/wporg-showcase-2022#225
This PR adds taxonomy to query-filter block apply button as per the discussion here.