Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Twitter icon to X (v2) #461

Merged

Conversation

ndiego
Copy link
Member

@ndiego ndiego commented Sep 28, 2023

Replaces #457

To correspond with X's new branding guidelines, let's switch out the old Twitter logo with X.

The footer links are powered by the Core Social Links block. This block received the X icon in Gutenberg 16.7.

Before After (w/ Gutenberg 16.7+)
image image

Warning
We might need to wait until Gutenberg 16.8 to implement. See #457

@ndiego ndiego marked this pull request as ready for review September 28, 2023 01:50
@ndiego ndiego requested a review from ryelle September 28, 2023 01:50
Copy link
Contributor

@ryelle ryelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, once we can update Gutenberg this should be good to merge (just approving in advance)

@adamwoodnz adamwoodnz linked an issue Oct 8, 2023 that may be closed by this pull request
@ndiego
Copy link
Member Author

ndiego commented Oct 16, 2023

@StevenDufresne @renintw has Gutenberg 16.8 been deployed? If so, this should be ready to go. Thanks!

@renintw
Copy link
Contributor

renintw commented Oct 16, 2023

The latest version of GB is 16.8.1.

And since the conflict from Blocks Everywhere + GB 16.7 that breaks the editor in the support forum appears to be resolved ​after GB 16.8 was released, unpin the GB version.

Unpin changeset: https://dotorg.trac.wordpress.org/changeset/21108/wordpress/website/wp-content/plugins
Changes: https://plugins.trac.wordpress.org/changeset?old_path=%2Fgutenberg%2Ftags%2F16.6.0&old=2963815&new_path=%2Fgutenberg%2Ftrunk&new=2978318

Also verified the correctness of this PR, here's the result
image

@renintw renintw merged commit 17f932d into WordPress:trunk Oct 16, 2023
@ndiego
Copy link
Member Author

ndiego commented Oct 16, 2023

Awesome, thanks @renintw!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Replace Twitter icon with X
3 participants