HTML API: Work on 62583 #7904
Draft
HTML API: Work on 62583 #7904
+72
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The BODY and HTML close tag handling in the HTML processor is somewhat unique in that the token is processed but it only changes internal state. No elements are pushed or popped, the stack of open elements is unchanged, and `next_token` must call itself recursively in order to add something to the element queue. Remove the `return true` from the close tag handling so that the processor proceeds until it has something to stop on in `next_token` in these cases.
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
…pi/ticket-62583-step-progress
sirreal
force-pushed
the
html-api/ticket-62583-step-progress
branch
from
fd7c37d
to
3e686aa
Compare
sirreal
commented
Nov 27, 2024
Comment on lines
+766
to
+770
| if ( empty( $this->element_queue ) ) { | ||
| if ( $this->step() ) { | ||
| assert( array() !== $this->element_queue ); | ||
| return $this->next_visitable_token(); | ||
| } |
There was a problem hiding this comment.
This is for debugging and is never intended to be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
Trac ticket: https://core.trac.wordpress.org/ticket/62583
Includes #7627.
This PR collects work to address https://core.trac.wordpress.org/ticket/62583. It adds an assertion to ensure that after
stepis called, there is something to be processed within next_token.This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.