Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add Test for is_blog_installed #7880

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

Debarghya-Banerjee
Copy link

@Debarghya-Banerjee Debarghya-Banerjee commented Nov 24, 2024

Trac Ticket: Core-54754

Summary

This PR adds a series of unit tests for the is_blog_installed() function in WordPress. The is_blog_installed() function checks if the WordPress installation is complete by verifying the existence of necessary options and tables in the database.

The tests ensure that the function behaves as expected under different conditions, including the presence or absence of the siteurl option, the state of the database tables, and certain WordPress constants like WP_REPAIRING.

Benefits

  • Coverage for Default Behavior: The tests ensure that is_blog_installed() behaves correctly in various scenarios, including default behavior, when siteurl is set or empty.

  • Edge Cases: The tests also account for edge cases such as the absence of siteurl, missing database tables, and when WordPress is in repair mode.

  • Performance Assurance: The caching test ensures that once the installation status is determined, it is cached for faster subsequent checks, improving performance.

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props debarghyabanerjee.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant