Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/delete attendee survey #1368

Merged
merged 6 commits into from
Sep 13, 2024
Merged

Fix/delete attendee survey #1368

merged 6 commits into from
Sep 13, 2024

Conversation

StevenDufresne
Copy link
Contributor

@StevenDufresne StevenDufresne commented Sep 12, 2024

This PR deletes the camptix-attendee-survey plugin as it's no longer used.

Related: #1367
Original PR: #997

@pkevan
Copy link
Contributor

pkevan commented Sep 12, 2024

Presume this is ready for review? Just still in draft?

@pkevan
Copy link
Contributor

pkevan commented Sep 12, 2024

Preferably when deleting, we should remove them in two commits, one for the activation stuff in https://github.com/WordPress/wordcamp.org/pull/1368/files#diff-c8e4e2f5dfad9d832ecf6d9b10ed8ad38c3f97d3b90f6d41a18a35aa4ba3d525, then a second for the unused code.

While not a huge issue on WordCamp, it is better to do it this way to avoid unnecessary fatals in the deploy process.

@StevenDufresne StevenDufresne marked this pull request as ready for review September 13, 2024 01:20
@pkevan pkevan merged commit 1578ac3 into production Sep 13, 2024
3 checks passed
@pkevan pkevan deleted the fix/delete-attendee-survey branch September 13, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants